Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.github/workflows/editorconfig.yml: remove branch restriction #94641

Merged
merged 1 commit into from Aug 4, 2020
Merged

.github/workflows/editorconfig.yml: remove branch restriction #94641

merged 1 commit into from Aug 4, 2020

Conversation

zowoq
Copy link
Contributor

@zowoq zowoq commented Aug 4, 2020

May as well remove this as it seems to be working okay and we don't want errors slipping back in via staging PRs.

I guess deleting the actions from release-20.09 after branch off is the simplest way of limiting these to master/unstable?

@Mic92
Copy link
Member

Mic92 commented Aug 4, 2020

Why do we want to not run this on 20.09?

@zowoq
Copy link
Contributor Author

zowoq commented Aug 4, 2020

Why would we care about these types of fixes on a branch that is going to be abandoned after a few months?

I think dealing with this on master will be enough trouble.

@Mic92
Copy link
Member

Mic92 commented Aug 4, 2020

I just thought it was more effort to remove this actually on every branch off. At least in long term.

@zowoq
Copy link
Contributor Author

zowoq commented Aug 4, 2020

I can change this and the ofborg wait action to be limited to master, staging, haskell, etc branches if you want?

@Mic92
Copy link
Member

Mic92 commented Aug 4, 2020

I think we can just merge this as it is.

@zowoq zowoq merged commit bcb7327 into NixOS:master Aug 4, 2020
@zowoq zowoq deleted the ecc-branch branch August 4, 2020 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants