Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

linux: enable io cost and io latency block group controller #93430

Merged
merged 1 commit into from Jul 31, 2020
Merged

linux: enable io cost and io latency block group controller #93430

merged 1 commit into from Jul 31, 2020

Conversation

symphorien
Copy link
Member

They are enabled by default on Arch.

Motivation for this change
Things done

tested compilation of

nix-build . -A linux_4_19 -A linux_5_4 -A linux_4_9 -A linux_5_6
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

srhb
srhb approved these changes Jul 19, 2020
View reviewed changes
Copy link
Contributor

@srhb srhb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me :)

@jonringer
Copy link
Contributor

I'm largely ignorant of what this means. Whats the benefit?

@Mic92
Copy link
Member

Mic92 commented Jul 31, 2020

I'm largely ignorant of what this means. Whats the benefit?

If it is used by systemd io is fairer scheduled between different services.

@srhb srhb merged commit 0b520e9 into NixOS:master Jul 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srhb srhb srhb approved these changes

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 501+ 10.rebuild-linux: 1001-2500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@symphorien @jonringer @Mic92 @srhb