Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sortmerna: 3.0.3 -> 4.2.0 #93429

Merged
merged 1 commit into from Jul 21, 2020
Merged

sortmerna: 3.0.3 -> 4.2.0 #93429

merged 1 commit into from Jul 21, 2020

Conversation

danieldk
Copy link
Contributor

@danieldk danieldk commented Jul 18, 2020 •
edited

Motivation for this change
  • Fixes build against rocksdb 6.10.2
  • Use dynamic rocksdb and zlib libraries
  • Build a dynamic binary

I don't know anything about sorting RNA, so all I can do is checking that the binary runs ;).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc: @prusnak

@danieldk
sortmerna: 3.0.3 -> 4.2.0
56c8413 
- Fixes build against rocksdb 6.10.2
- Use dynamic rocksdb and zlib libraries
- Build a dynamic binary
@ofborg ofborg bot requested a review from luispedro July 18, 2020 16:27
@danieldk
Copy link
Contributor Author

Merging this - sortmerna is broken since the rocksdb update. So this change is a net improvement, since it makes it build again.

@danieldk danieldk merged commit 622150e into NixOS:master Jul 21, 2020
@danieldk danieldk deleted the sortmerna-4.2.0 branch July 21, 2020 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luispedro luispedro Awaiting requested review from luispedro

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@danieldk