Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

appimage: switch to gst-plugins-base 1.0 #93398

Merged
merged 1 commit into from Jul 21, 2020

Conversation

IvarWithoutBones
Copy link
Member

@IvarWithoutBones IvarWithoutBones commented Jul 18, 2020

Motivation for this change

gst-plugins-base 0.10 is depricated and marked as broken as of d034a00.

Not sure if we should delete GStreamer 0.10 as well, as version 1.0 is already in the package. (#39975)

fixes: #93174

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
19 packages built:
     Sylk appimage-run deltachat-electron devdocs-desktop irccloud joplin-desktop ledger-live-desktop 
     marktext minetime notable obsidian runwayml ssb-patchwork standardnotes station tusk unityhub 
     wootility zulip
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Flakebi
Copy link
Member

Flakebi commented Jul 20, 2020

Result of nixpkgs-review pr 93398 1

19 packages built:
- Sylk
- appimage-run
- deltachat-electron
- devdocs-desktop
- irccloud
- joplin-desktop
- ledger-live-desktop
- marktext
- minetime
- notable
- obsidian
- runwayml
- ssb-patchwork
- standardnotes
- station
- tusk
- unityhub
- wootility
- zulip

1 similar comment
@thorstenweber83
Copy link
Contributor

Result of nixpkgs-review pr 93398 1

19 packages built:
- Sylk
- appimage-run
- deltachat-electron
- devdocs-desktop
- irccloud
- joplin-desktop
- ledger-live-desktop
- marktext
- minetime
- notable
- obsidian
- runwayml
- ssb-patchwork
- standardnotes
- station
- tusk
- unityhub
- wootility
- zulip

@afontaine afontaine mentioned this pull request Jul 21, 2020
10 tasks
@ryantm ryantm merged commit b78ffda into NixOS:master Jul 21, 2020
@IvarWithoutBones IvarWithoutBones deleted the appimage-run-fix branch July 21, 2020 15:35
@@ -163,7 +164,6 @@ rec {
SDL2_ttf
SDL2_mixer
gstreamer
Copy link
Contributor

@jtojnar jtojnar Aug 22, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same should be likely done with gstreamer.

jtojnar added a commit to jtojnar/nixpkgs that referenced this pull request Sep 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

appimage-run: depends on broken gst-plugins-base
5 participants