Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
base: 60c9c3a2338e
Choose a base ref
...
head repository: NixOS/nixpkgs
compare: cf059b32d98e
Choose a head ref
  • 2 commits
  • 1 file changed
  • 2 contributors

Commits on Jul 18, 2020

  1. petsc: Fix install_name_tool patch 

    The PETSc library's config/install.py script checks whether
/usr/bin/install_name_tool is an existing file:

https://gitlab.com/petsc/petsc/-/blob/master/config/install.py#L368

Therefore, it is not enough to replace it with something that we expect
to be on the PATH, as this will cause the linked if statement to be
silently skipped. The consequence is that applications linked against
this version of petsc will fail at runtime on MacOS with a dynamic
loading error.

Instead, we should replace install_name_tool with the absolute path of a
binary we know will be present at build time.

Note that this should be fixed upstream as well, but this is sufficient
to fix the runtime error.
    Jack Coughlin committed Jul 18, 2020
    Copy the full SHA
    8a65fe8 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #93428 from johnbcoughlin/petsc-install_name_tool 

    petsc: Fix install_name_tool patch
    @danieldk
    danieldk committed Jul 18, 2020
    Copy the full SHA
    cf059b3 View commit details
    Browse the repository at this point in the history