Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sublime4-dev: init at 4079 #93437

Closed
wants to merge 1 commit into from
Closed

sublime4-dev: init at 4079 #93437

wants to merge 1 commit into from

Conversation

jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Jul 18, 2020 •
edited

Motivation for this change

Development version of the upcoming Sublime Text, not merging this since it did not yet reach general availability.

  • works with my 7 year old license so far
  • i686 is no longer supported
  • aarch64 support has been added
  • adds harware accelerated (needs libGL.so.1)
  • adds python 3.8 plugin host (needs libssl.so and libcrypto.so)
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from wmertens and zimbatm July 18, 2020 19:17
wmertens
wmertens approved these changes Jul 18, 2020
View reviewed changes
Copy link
Contributor

@wmertens wmertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. I'm wondering though if this shouldn't use steamenv. I use vscode and it's a pain to keep the plugins working, I'm thinking it should be used there too.

pkgs/applications/editors/sublime/4/common.nix Show resolved Hide resolved
@jtojnar
Copy link
Contributor Author

jtojnar commented Jul 18, 2020

I am not sure how would steamenv help. Is not that just a chroot with tons of outdated dependencies?

@wmertens
Copy link
Contributor

I saw it used in some places and was hoping it would solve the plugin woes of vscode but didn't investigate closer yet.
I was under the impression that you can add your own dependencies, thus pretending to be a "normal distro"

@jtojnar jtojnar changed the title sublime4-dev: init at 4074 sublime4-dev: init at 4079 Jul 18, 2020
@ofborg ofborg bot requested a review from wmertens July 18, 2020 23:41
@jtojnar
sublime4-dev: init at 4079
b1f47a4 
* works with my 7 year old license so far
* i686 is no longer supported
* aarch64 support has been added
* adds harware accelerated (needs libGL.so.1)
* adds python 3.8 plugin host (needs libssl.so and libcrypto.so)
@stale
Copy link

stale bot commented Jan 19, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jan 19, 2021
@MasseGuillaume MasseGuillaume mentioned this pull request Apr 13, 2021
Closed
10 tasks
@jtojnar jtojnar mentioned this pull request May 22, 2021
Merged
9 tasks
@jtojnar
Copy link
Contributor Author

jtojnar commented May 26, 2021

Added in #124057

@jtojnar jtojnar closed this May 26, 2021
@jtojnar jtojnar deleted the subl4 branch May 26, 2021 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zimbatm zimbatm Awaiting requested review from zimbatm

@wmertens wmertens Awaiting requested review from wmertens

Assignees
No one assigned
Labels
2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jtojnar @wmertens