vivado: init at 2017.2 #93436

matthuszagh · 2020-07-18T18:58:02Z

Adds Vivado 2017.2. Note that most of the work is not my own. I received permission to create this PR by @lukaslaobeyer here. Since Vivado is not open source, you must prefetch the file (see derivation message) in order to build it. Finally, 2017 is not the newest version, but I was unable to make much headway on 2019.

9999years · 2020-09-21T14:58:45Z

pkgs/applications/science/electronics/vivado/default.nix

+  # requireFile prevents rehashing each time, which saves time during
+  # rebuilds.
+  src = requireFile rec {
+    name = "Xilinx_Vivado_SDK_2017.2_0616_1.tar.gz";
+    message = ''
+      This nix expression requires that ${name} is already part of the store.
+      Login to Xilinx, download from
+      https://www.xilinx.com/support/download.html,
+      rename the file to ${name}, and add it to the nix store with
+      "nix-prefetch-url file:///path/to/${name}".
+    '';
+    sha256 = "06pb4wjz76wlwhhzky9vkyi4aq6775k63c2kw3j9prqdipxqzf9j";
+  };


Can we make the requireFile arguments (name and sha256) arguments with default values to the derivation (i.e. after line 21)? That'll make it a bit easier for people to upgrade on their own (with vivado.override { name = "..."; sha256 = "..."; } rather than making an overlay) after Xilinx releases new versions that haven't been hashed/submitted here yet.

@9999years definitely. The only thing is I can't guarantee the builder will work for anything other than this version. For instance, the builder failed for 2019.

with vivado.override { name = "..."; sha256 = "..."; } rather than making an overlay

For instance, the builder failed for 2019.

Than we should not add this and let people overwrite it with overwriteAttr

pkgs/applications/science/electronics/vivado/default.nix

pkgs/applications/science/electronics/vivado/builder.sh

stale · 2021-07-21T01:11:59Z

I marked this as stale due to inactivity. → More info

RaitoBezarius · 2022-12-01T19:56:54Z

@flokli you told me you had some Vivado exprs, do you know which version it is for?
@matthuszagh Can I do something to help you get this merged?

matthuszagh · 2022-12-01T20:36:17Z

@RaitoBezarius thanks for the reminder - I'd let this PR slip. I think the only remaining thing to do is to migrate the stuff from builder.sh into the appropriate phases. I'm going to try to get started on that, but I'm a bit strapped for time so I'm not entirely sure how long it will take. If you're feeling impatient, I wouldn't be opposed to you tackling some of that.

matthuszagh · 2022-12-01T23:19:12Z

I made a simple attempt to migrate builder.sh into default.nix. Builds fine, although I haven't tested the vivado binary since I'm running into this at the moment.

matthuszagh · 2022-12-01T23:21:39Z

Something we might want to consider is the installed modules are currently not configurable. It might be better to allow these to be easily overridden. I don't know what happens with the installation when modules that are not supported by the free edition are selected. But, for instance, some Kintex-7 devices are available in the free edition and these are not currently installed.

RaitoBezarius · 2022-12-02T00:03:06Z

I made a simple attempt to migrate builder.sh into default.nix. Builds fine, although I haven't tested the vivado binary since I'm running into this at the moment.

Do you know which glibc is needed and can you attempt a explicit LD_PRELOAD?

RaitoBezarius · 2022-12-02T00:03:39Z

Something we might want to consider is the installed modules are currently not configurable. It might be better to allow these to be easily overridden. I don't know what happens with the installation when modules that are not supported by the free edition are selected. But, for instance, some Kintex-7 devices are available in the free edition and these are not currently installed.

I think we can revisit this later, ultimately, but it's good to keep it in mind.

pkgs/applications/science/electronics/vivado/default.nix

SuperSandro2000 · 2022-12-02T02:00:15Z

pkgs/applications/science/electronics/vivado/default.nix

+  dontBuild = true;
+
+  installPhase = ''
+    # generate an installation config file


From where did you get this?

This, along with pretty much everything else, I took from the original derivation (see this). Do you want something changed from it? Some of these settings could probably exposed so that someone can customize them more easily.

SuperSandro2000 · 2022-12-02T02:00:32Z

pkgs/applications/science/electronics/vivado/default.nix

+    CreateFileAssociation=0
+    EOF
+
+    ($(pwd)/xsetup --agree 3rdPartyEULA,WebTalkTerms,XilinxEULA --batch Install --config install_config.txt || true) | while read line


Suggested change

($(pwd)/xsetup --agree 3rdPartyEULA,WebTalkTerms,XilinxEULA --batch Install --config install_config.txt || true) | while read line

(./xsetup --agree 3rdPartyEULA,WebTalkTerms,XilinxEULA --batch Install --config install_config.txt || true) | while read line

Why do we allow it to fail?

I don't know, I didn't write it. But, I suppose I can test what happens when it does fail.

pkgs/applications/science/electronics/vivado/default.nix

SuperSandro2000 · 2022-12-02T02:01:58Z

pkgs/applications/science/electronics/vivado/default.nix

+    sed -i -- 's|`basename "\$0"`|xsdk|g' $out/opt/SDK/2017.2/bin/.xsdk-wrapped
+  '';
+
+  libPath = lib.makeLibraryPath [


Please move this into a let in to postFixup

I get an error when I try to run vivado after doing this: application-specific initialization failed: couldn't load file "librdi_commontasks.so": libtinfo.so.5: cannot open shared object file: No such file or directory. It works if I keep it out of the let though.

Yes, this is because your are using bash variables instead of nix ones in preFixup. Please use nix variables there.

pkgs/applications/science/electronics/vivado/default.nix

flokli · 2022-12-05T16:44:37Z

@flokli you told me you had some Vivado exprs, do you know which version it is for? @matthuszagh Can I do something to help you get this merged?

@RaitoBezarius I have a vivado 2019.2 expression, you can source it from here: https://github.com/flokli/pynq/blob/master/nix/pkgs/vivado/default.nix

matthuszagh · 2023-01-05T03:30:33Z

@SuperSandro2000 I left a few of your comments open because I'm not totally sure I addressed them, but I did update a lot of things. Let me know what you think now.

SuperSandro2000 · 2023-01-06T14:13:19Z

pkgs/applications/science/electronics/vivado/default.nix

+    # Patch ELFs
+    for f in $out/opt/Vivado/$version/bin/unwrapped/lnx64.o/*
+    do
+        patchelf --set-interpreter "$(cat $NIX_CC/nix-support/dynamic-linker)" $f || true
+    done
+    for f in $out/opt/SDK/$version/bin/unwrapped/lnx64.o/*
+    do
+        patchelf --set-interpreter "$(cat $NIX_CC/nix-support/dynamic-linker)" $f || true
+    done


Suggested change

# Patch ELFs

for f in $out/opt/Vivado/$version/bin/unwrapped/lnx64.o/*

do

patchelf --set-interpreter "$(cat $NIX_CC/nix-support/dynamic-linker)" $f || true

done

for f in $out/opt/SDK/$version/bin/unwrapped/lnx64.o/*

do

patchelf --set-interpreter "$(cat $NIX_CC/nix-support/dynamic-linker)" $f || true

done

# Patch ELFs

for f in $out/opt/Vivado/$version/bin/unwrapped/lnx64.o/*; do

patchelf --set-interpreter "$(cat $NIX_CC/nix-support/dynamic-linker)" $f

done

for f in $out/opt/SDK/$version/bin/unwrapped/lnx64.o/*; do

patchelf --set-interpreter "$(cat $NIX_CC/nix-support/dynamic-linker)" $f

done

the build should fail if patchelf fails

SuperSandro2000 · 2023-01-06T14:13:54Z

pkgs/applications/science/electronics/vivado/default.nix

+    wrapProgram $out/opt/Vivado/$version/bin/vivado --prefix LD_LIBRARY_PATH : "$libPath"
+    wrapProgram $out/opt/SDK/$version/bin/xsdk --prefix LD_LIBRARY_PATH : "$libPath"
+    wrapProgram $out/opt/SDK/$version/eclipse/lnx64.o/eclipse --prefix LD_LIBRARY_PATH : "$libPath"
+    wrapProgram $out/opt/SDK/$version/tps/lnx64/jre/bin/java --prefix LD_LIBRARY_PATH : "$libPath"


Suggested change

wrapProgram $out/opt/Vivado/$version/bin/vivado --prefix LD_LIBRARY_PATH : "$libPath"

wrapProgram $out/opt/SDK/$version/bin/xsdk --prefix LD_LIBRARY_PATH : "$libPath"

wrapProgram $out/opt/SDK/$version/eclipse/lnx64.o/eclipse --prefix LD_LIBRARY_PATH : "$libPath"

wrapProgram $out/opt/SDK/$version/tps/lnx64/jre/bin/java --prefix LD_LIBRARY_PATH : "$libPath"

for file in $out/opt/Vivado/$version/bin/vivado $out/opt/SDK/$version/bin/xsdk $out/opt/SDK/$version/eclipse/lnx64.o/eclipse $out/opt/SDK/$version/tps/lnx64/jre/bin/java ; do

wrapProgram $file --prefix LD_LIBRARY_PATH : "$libPath"

done

SuperSandro2000 · 2023-01-06T14:14:22Z

pkgs/applications/science/electronics/vivado/default.nix

+    # Hack around lack of libtinfo in NixOS
+    ln -s $ncurses/lib/libncursesw.so.6 $out/opt/Vivado/$version/lib/lnx64.o/libtinfo.so.5
+    ln -s $ncurses/lib/libncursesw.so.6 $out/opt/SDK/$version/lib/lnx64.o/libtinfo.so.5


We can change that name with patchelf which is a bit cleaner

SuperSandro2000 · 2023-01-06T14:14:45Z

pkgs/applications/science/electronics/vivado/default.nix

+    # Patch installed files
+    patchShebangs $out/opt/Vivado/$version/bin
+    patchShebangs $out/opt/SDK/$version/bin


Suggested change

# Patch installed files

patchShebangs $out/opt/Vivado/$version/bin

patchShebangs $out/opt/SDK/$version/bin

patchShebangs $out/opt/{Vivado,SDK}/$version/bin

flokli · 2023-01-12T14:12:29Z

What's with #93436 (comment) ?

ofborg bot added 8.has: package (new) 11.by: package-maintainer 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Jul 18, 2020

9999years reviewed Sep 21, 2020

View reviewed changes

SuperSandro2000 requested changes Jan 18, 2021

View reviewed changes

pkgs/applications/science/electronics/vivado/default.nix Outdated Show resolved Hide resolved

pkgs/applications/science/electronics/vivado/builder.sh Outdated Show resolved Hide resolved

SuperSandro2000 added the 2.status: merge conflict label Jan 18, 2021

stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 21, 2021

stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Dec 1, 2022

matthuszagh added 2 commits December 1, 2022 12:06

vivado: init at 2017.2

71ca02a

replace stdenv.lib with lib

2a7de51

matthuszagh force-pushed the vivado branch from 5845946 to 2a7de51 Compare December 1, 2022 20:33

ofborg bot removed the 2.status: merge conflict label Dec 1, 2022

SuperSandro2000 requested changes Dec 2, 2022

View reviewed changes

matthuszagh added 7 commits December 2, 2022 21:41

vivado: migrate builder.sh to buildPhase

5b45e40

vivado: don't inherit ncurses5

cb4b3b1

vivado: no need to source $stdenv/setup

8b046d8

vivado: don't unpack in buildPhase

b6b9012

vivado: replace 2017.2 with $version

8c97a14

vivado: move pre-build patching to postPatch

665fa0b

vivado: move buildPhase contents to installPhase

34747c1

matthuszagh added 2 commits December 5, 2022 11:54

vivado: add whitespace to installPhase

529374d

vivado: move parts of installPhase into preFixup

46d4ac8

matthuszagh force-pushed the vivado branch from 01d3d35 to 46d4ac8 Compare December 5, 2022 21:30

matthuszagh added 3 commits December 5, 2022 13:33

vivado: reorder src and buildInputs

ac12b90

vivado: migrate some buildInputs to nativeBuildInputs and remove others

526557d

vivado: delete builder.sh

a298b28

SuperSandro2000 reviewed Jan 6, 2023

View reviewed changes

wegank added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Mar 19, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

vivado: init at 2017.2 #93436

vivado: init at 2017.2 #93436

matthuszagh commented Jul 18, 2020 •

edited

9999years Sep 21, 2020

matthuszagh Sep 22, 2020

SuperSandro2000 Dec 2, 2022

stale bot commented Jul 21, 2021

RaitoBezarius commented Dec 1, 2022

matthuszagh commented Dec 1, 2022

matthuszagh commented Dec 1, 2022

matthuszagh commented Dec 1, 2022 •

edited

RaitoBezarius commented Dec 2, 2022

RaitoBezarius commented Dec 2, 2022

SuperSandro2000 Dec 2, 2022

matthuszagh Dec 3, 2022 •

edited

SuperSandro2000 Dec 2, 2022

matthuszagh Dec 3, 2022

SuperSandro2000 Dec 2, 2022

matthuszagh Jan 5, 2023

SuperSandro2000 Jan 6, 2023

flokli commented Dec 5, 2022

matthuszagh commented Jan 5, 2023

SuperSandro2000 Jan 6, 2023

SuperSandro2000 Jan 6, 2023

SuperSandro2000 Jan 6, 2023

SuperSandro2000 Jan 6, 2023

flokli commented Jan 12, 2023

	($(pwd)/xsetup --agree 3rdPartyEULA,WebTalkTerms,XilinxEULA --batch Install --config install_config.txt \|\| true) \| while read line
	(./xsetup --agree 3rdPartyEULA,WebTalkTerms,XilinxEULA --batch Install --config install_config.txt \|\| true) \| while read line

vivado: init at 2017.2 #93436

Are you sure you want to change the base?

vivado: init at 2017.2 #93436

Conversation

matthuszagh commented Jul 18, 2020 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

stale bot commented Jul 21, 2021

RaitoBezarius commented Dec 1, 2022

matthuszagh commented Dec 1, 2022

matthuszagh commented Dec 1, 2022

matthuszagh commented Dec 1, 2022 • edited

RaitoBezarius commented Dec 2, 2022

RaitoBezarius commented Dec 2, 2022

Choose a reason for hiding this comment

matthuszagh Dec 3, 2022 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

flokli commented Dec 5, 2022

matthuszagh commented Jan 5, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

flokli commented Jan 12, 2023

matthuszagh commented Jul 18, 2020 •

edited

matthuszagh commented Dec 1, 2022 •

edited

matthuszagh Dec 3, 2022 •

edited