Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

palemoon: 28.10.0 -> 28.12.0 #93407

Merged
merged 1 commit into from Aug 17, 2020
Merged

palemoon: 28.10.0 -> 28.12.0 #93407

merged 1 commit into from Aug 17, 2020

Conversation

OPNA2608
Copy link
Contributor

@OPNA2608 OPNA2608 commented Jul 18, 2020 •
edited

Motivation for this change

http://www.palemoon.org/releasenotes.shtml

"This is a development, bugfix and security update."
(CVE-2020-12422, CVE-2020-12418)

Includes other incremental improvements to the expression.

Cherry-pick for 20.03: #95654

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from AndersonTorres July 18, 2020 11:40
@OPNA2608 OPNA2608 changed the title palemoon: 28.10.0 -> 28.11.0 palemoon: 28.10.0 -> 28.12.0 Aug 7, 2020
@OPNA2608
Copy link
Contributor Author

OPNA2608 commented Aug 7, 2020

Bumped to 28.12.0, more CVEs fixed.

Also using upstream's desktop file now, installing 1 more size variation of the icon and added an updateScript.

@OPNA2608 OPNA2608 mentioned this pull request Aug 17, 2020
Merged
10 tasks
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/259

@worldofpeace worldofpeace merged commit 1219001 into NixOS:master Aug 17, 2020
@OPNA2608 OPNA2608 deleted the update-palemoon-28.11.0 branch September 27, 2022 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndersonTorres AndersonTorres Awaiting requested review from AndersonTorres

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@OPNA2608 @nixos-discourse @worldofpeace