Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nix
base: 3f01fa1c9c1b
Choose a base ref
...
head repository: NixOS/nix
compare: 0e9fb4a8692f
Choose a head ref
  • 2 commits
  • 1 file changed
  • 2 contributors

Commits on Jul 17, 2020

  1. nix edit: call restoreSignals() before execvp-ing the $EDITOR 

    Currently resizing of the terminal doesn't play nicely with
nix edit when using kakoune as the editor, as it relies on the
SIGWINCH signal which is trapped by nix. How this is not a problem
with e.g. vim is beyond me.

Virtually all other exec* calls are following a call to
restoreSignals(). This commit adds this behavior to nix edit
as well.
    @BurNiinTRee
    BurNiinTRee committed Jul 17, 2020
    Copy the full SHA
    bc73590 View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2020

  1. Merge pull request #3828 from BurNiinTRee/restore-signals-before-edit 

    nix edit: call restoreSignals() before `execvp`-ing the $EDITOR
    @edolstra
    edolstra committed Jul 18, 2020
    Copy the full SHA
    0e9fb4a View commit details
    Browse the repository at this point in the history