Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fedora-coreos-config-transpiler: use upstream vendor #93392

Merged
merged 1 commit into from Jul 19, 2020
Merged

fedora-coreos-config-transpiler: use upstream vendor #93392

merged 1 commit into from Jul 19, 2020

Conversation

zowoq
Copy link
Contributor

@zowoq zowoq commented Jul 18, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from ruuda and kalbasit July 18, 2020 08:33
@ruuda
Copy link
Contributor

ruuda commented Jul 18, 2020

I’m not really familiar with the Go ecosystem myself, I added the vendorSha256 because @flokli recommended it here. What are the differences between having vendorSha256 = null vs deleteVendor = true?

@zowoq
Copy link
Contributor Author

zowoq commented Jul 18, 2020

As upstream has a /vendor checked in to their repo vendorSha256 = null should be sufficient, deleteVendor isn't needed unless the deps are incomplete/broken.

danieldk
danieldk reviewed Jul 19, 2020
View reviewed changes
Copy link
Contributor

@danieldk danieldk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 93392 1

1 package built:
- fedora-coreos-config-transpiler

Confirmed that the binary works.

@danieldk danieldk merged commit 5b55f25 into NixOS:master Jul 19, 2020
@zowoq zowoq deleted the fcct branch July 19, 2020 08:44
@ruuda
Copy link
Contributor

ruuda commented Jul 19, 2020

As upstream has a /vendor checked in to their repo vendorSha256 = null should be sufficient, deleteVendor isn't needed unless the deps are incomplete/broken.

Ah, I see, thanks for the clarification!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieldk danieldk danieldk left review comments

@ruuda ruuda Awaiting requested review from ruuda

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zowoq @ruuda @danieldk