Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

p7zip: fix build when enableUnfree is true #93439

Merged
merged 1 commit into from Jul 18, 2020
Merged

p7zip: fix build when enableUnfree is true #93439

merged 1 commit into from Jul 18, 2020

Conversation

cript0nauta
Copy link
Contributor

@cript0nauta cript0nauta commented Jul 18, 2020 •
edited

chmod +x install.sh was only being executed when enableUnfree was
false. Therefore, building p7zip with enableUnfree set to true would fail
because install.sh was not an executable file.

Motivation for this change

Running NIXPKGS_ALLOW_UNFREE=1 nix-build -E 'with import <nixpkgs> {}; p7zip.override { enableUnfree = true; }' was failing, so I was not able to uncompress .rar files.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@cript0nauta
p7zip: fix build when enableUnfree is true
410dbaa 
`chmod +x install.sh` was only being executed when enableUnfree was
false. Therefore, building p7zip with enableUnfree set to true would fail
because install.sh was not an executable file.
@ofborg ofborg bot requested a review from 7c6f434c July 18, 2020 20:59
@worldofpeace worldofpeace merged commit a5fc5da into NixOS:master Jul 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cript0nauta @worldofpeace