Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rambox: add wrapGAppsHook #93459

Merged
merged 1 commit into from Jul 20, 2020
Merged

rambox: add wrapGAppsHook #93459

merged 1 commit into from Jul 20, 2020

Conversation

ghost
Copy link

@ghost ghost commented Jul 19, 2020

Motivation for this change

Closes #93289
Original error is not reproduceable in my environment so @billop please test

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ghost ghost requested review from worldofpeace and Ma27 July 19, 2020 05:03
@Ma27
Copy link
Member

Ma27 commented Jul 20, 2020 •
edited

I can reproduce the issue, however your only works on X11 and not on Wayland. I'm currently investigating.

EDIT: my mistake, for some reason, my WM moved the upload dialog to a different workspace, everything's working as expected.

@Ma27 Ma27 merged commit 358cecf into NixOS:master Jul 20, 2020
@ghost
Copy link
Author

ghost commented Jul 20, 2020

@Ma27 thank you!

@ghost ghost deleted the rambox branch July 20, 2020 10:31
@worldofpeace
Copy link
Contributor

We have double wrapper in the postFixup here.
See You can also pass additional arguments to makeWrapper using gappsWrapperArgs in preFixup hook: https://nixos.org/nixpkgs/manual/#ssec-gnome-hooks

@ghost
Copy link
Author

ghost commented Jul 23, 2020

@worldofpeace Good catch! Created a new PR #93617 93689

@deliciouslytyped
Copy link
Contributor

@gnidorah is the first pr you linked the right one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace Awaiting requested review from worldofpeace

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rambox can't find GSettings schemas
3 participants
@Ma27 @worldofpeace @deliciouslytyped