Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate fetch target in buildBazelPackage + fixup. #93443

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Separate fetch target in buildBazelPackage + fixup. #93443

wants to merge 1 commit into from

Conversation

robinp
Copy link
Contributor

@robinp robinp commented Jul 18, 2020

Separate fetch target is useful to build a dependency set over the full
workspace, to be shared between multiple build target invocations.

Shebang patching is needed for sandboxed builds to succeed.

Plus moving an &&-ed test command to if-based, so it doesn't fail if the
test condition fails.

Things done

Tested by running buildBazelPackage in sandboxed build environment.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@robinp
Separate fetch target in buildBazelPackage + fixup.
6be8191 
Separate fetch target is useful to build a dependency set over the full
workspace, to be shared between multiple build target invocations.

Shebang patching is needed for sandboxed builds to succeed.

Plus moving an &&-ed test command to if-based, so it doesn't fail if the
test condition fails.
@stale
Copy link

stale bot commented Apr 18, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Apr 18, 2021
@wegank wegank marked this pull request as draft March 20, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
2.status: merge conflict 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@robinp @ryantm