Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/speechd: init module #93416

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

nixos/speechd: init module #93416

wants to merge 1 commit into from

Conversation

davidak
Copy link
Member

@davidak davidak commented Jul 18, 2020

Motivation for this change

Closes #39500

This might be a start. I need a test system next to install nixos from this PR.

I'm not sure yet how speechd works at all.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@davidak
Copy link
Member Author

davidak commented Jul 18, 2020

@jtojnar would you implement the options just like the package?

services.speechd.withFlite = true;
services.speechd.withEspeak = true;
services.speechd.withPico = true;

Do we need more options like config file?

@jtojnar
Copy link
Contributor

jtojnar commented Jul 18, 2020

I think it should be sufficient to provide package option where you would pass the configured package.

@stale
Copy link

stale bot commented Jan 15, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jan 15, 2021
@davidak
Copy link
Member Author

davidak commented Jan 15, 2021

oh no

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jan 15, 2021
@stale
Copy link

stale bot commented Jul 14, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 14, 2021
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
2.status: merge conflict 6.topic: nixos 8.has: module (update)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add speechd module
3 participants
@davidak @jtojnar @wegank