Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scons: 4.0.0 -> 4.0.1 #93415

Merged
merged 1 commit into from Jul 19, 2020
Merged

scons: 4.0.0 -> 4.0.1 #93415

merged 1 commit into from Jul 19, 2020

Conversation

primeos
Copy link
Member

@primeos primeos commented Jul 18, 2020

Motivation for this change

nixpkgs-review result (failures are unrelated):

17 package updated:
bombono d1x-rebirth-full d2x-rebirth-full dxx-rebirth dxx-rebirth dxx-rebirth endless-sky fceux-unstable gambatte godot goxel hammer-e7aa734 mariadb-galera rmlint scons (4.0.0 → 4.0.1) the-powder-toy xsettingsd

2 package failed to build:
d1x-rebirth-full d2x-rebirth-full

13 package built:
bombono d1x_rebirth endless-sky fceux gambatte godot goxel hammer mariadb-galera rmlint scons the-powder-toy xsettingsd
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant