Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perlPackages.FilePid: import Debian patch #93385

Merged
merged 1 commit into from Jul 22, 2020
Merged

perlPackages.FilePid: import Debian patch #93385

merged 1 commit into from Jul 22, 2020

Conversation

kini
Copy link
Member

@kini kini commented Jul 18, 2020 •
edited

Motivation for this change

See:

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@kini kini requested a review from limeytexan July 20, 2020 03:20
stigtsp
stigtsp approved these changes Jul 21, 2020
View reviewed changes
Copy link
Member

@stigtsp stigtsp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@stigtsp stigtsp requested a review from aanderse July 21, 2020 17:17
@aanderse
Copy link
Member

@GrahamcOfBorg build perlPackages.FilePid perldevelPackages.FilePid

@aanderse aanderse merged commit 9b6a00b into NixOS:master Jul 22, 2020
@kini kini deleted the perlPackages.FilePid/missing-pidfile-patch branch July 31, 2020 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stigtsp stigtsp stigtsp approved these changes

@limeytexan limeytexan Awaiting requested review from limeytexan

@aanderse aanderse Awaiting requested review from aanderse

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kini @aanderse @stigtsp