Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vim-plugins: add 13 plugins #93449

Merged
merged 16 commits into from Jul 19, 2020
Merged

vim-plugins: add 13 plugins #93449

merged 16 commits into from Jul 19, 2020

Conversation

ndarwincorn
Copy link
Contributor

Motivation for this change

Migrated my init.nvim to nix/home-manager and realized how many of the plugins I use are missing.

Things done

Ran the following command: update.py --add "dmix/elvish.vim" ... --add "yuki-ycino/ncm2-dictionary"

Added overrides for dependencies for ncm2-neoinclude, ncm2-neosnippet, ncm2-syntax.

Built/installed them by sourcing my local nixpkgs repo.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ndarwincorn
vimPlugins: update
b077859
@ndarwincorn
vimPlugins.elvish-vim: init at 2019-06-29
501a9de
@ndarwincorn
vimPlugins.vim-packer: init at 2018-11-11
5096769
@ndarwincorn
vimPlugins.vim-vagrant: init at 2018-11-11
2904fb7
@ndarwincorn
vimPlugins.vim-terraform-completion: init at 2019-07-28
44178a8
@ndarwincorn
vimPlugins.ncm2-cssomni: init at 2018-07-09
cc7012a
@ndarwincorn
vimPlugins.ncm2-github: init at 2018-08-01
260182c
@ndarwincorn
vimPlugins.ncm2-html-subscope: init at 2018-07-01
03d2363
@ndarwincorn
vimPlugins.ncm2-markdown-subscope: init at 2020-03-09
b667ccf
@ndarwincorn
vimPlugins.ncm2-neoinclude: init at 2020-01-09
0e24f74
@ndarwincorn
vimPlugins.ncm2-neosnippet: init at 2019-01-26
82b1b19
@ndarwincorn
vimPlugins.ncm2-syntax: init at 2018-12-11
466872e
@ndarwincorn
vimPlugins.ncm2-tagprefix: init at 2018-11-08
fbd0c09
@ndarwincorn
vimPlugins.ncm2-vim: init at 2018-08-15
fc17201
@ndarwincorn
vimPlugins.ncm2-dictionary: init at 2018-11-15
f826149
@ndarwincorn
vimPlugins: add overrides for new ncm2 plugin deps
ef0df90
@ofborg ofborg bot requested review from jorsn and jagajaga July 19, 2020 00:25
typetetris
typetetris reviewed Jul 19, 2020
View reviewed changes
Copy link
Contributor

@typetetris typetetris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[x] versions in commit messages match generated file
[x] all new plugins have MIT license except vim-packer and vim-vagrant which have ISC License

@typetetris
Copy link
Contributor

Result of nixpkgs-review pr 93449 1

1 package failed to build:
- vimPlugins.YouCompleteMe
71 packages built:
- vimPlugins.ale
- vimPlugins.ansible-vim
- vimPlugins.calendar-vim
- vimPlugins.coc-go
- vimPlugins.coc-nvim
- vimPlugins.completion-nvim
- vimPlugins.conjure
- vimPlugins.csv-vim
- vimPlugins.defx-nvim
- vimPlugins.denite-nvim
- vimPlugins.deol-nvim
- vimPlugins.deoplete-fish
- vimPlugins.deoplete-khard
- vimPlugins.deoplete-lsp
- vimPlugins.deoplete-nvim
- vimPlugins.dhall-vim
- vimPlugins.elvish-vim
- vimPlugins.iceberg-vim
- vimPlugins.jedi-vim
- vimPlugins.kotlin-vim
- vimPlugins.lh-vim-lib
- vimPlugins.lightline-vim
- vimPlugins.ncm2-cssomni
- vimPlugins.ncm2-dictionary
- vimPlugins.ncm2-github
- vimPlugins.ncm2-html-subscope
- vimPlugins.ncm2-markdown-subscope
- vimPlugins.ncm2-neoinclude
- vimPlugins.ncm2-neosnippet
- vimPlugins.ncm2-syntax
- vimPlugins.ncm2-tagprefix
- vimPlugins.ncm2-vim
- vimPlugins.neoformat
- vimPlugins.neomake
- vimPlugins.neosnippet-vim
- vimPlugins.nerdtree
- vimPlugins.neuron-vim
- vimPlugins.nvim-lsp
- vimPlugins.nvim-treesitter
- vimPlugins.onedark-vim
- vimPlugins.open-browser-github-vim
- vimPlugins.splitjoin-vim
- vimPlugins.traces-vim
- vimPlugins.vim
- vimPlugins.vim-airline
- vimPlugins.vim-dasht
- vimPlugins.vim-flutter
- vimPlugins.vim-go
- vimPlugins.vim-grepper
- vimPlugins.vim-isort
- vimPlugins.vim-jsx-typescript
- vimPlugins.vim-lion
- vimPlugins.vim-lsc
- vimPlugins.vim-markdown
- vimPlugins.vim-move
- vimPlugins.vim-orgmode
- vimPlugins.vim-packer
- vimPlugins.vim-pandoc
- vimPlugins.vim-ruby
- vimPlugins.vim-sandwich
- vimPlugins.vim-snippets
- vimPlugins.vim-terraform
- vimPlugins.vim-terraform-completion
- vimPlugins.vim-test
- vimPlugins.vim-vagrant
- vimPlugins.vim-which-key
- vimPlugins.vimfiler-vim
- vimPlugins.vimtex
- vimPlugins.vista-vim
- vimPlugins.yats-vim
- vimPlugins.zig-vim

@typetetris
Copy link
Contributor

Doesn't seem to be this pull requests fault:

builder for '/nix/store/6rb7gicz0chyxw26q3w7r6ff6bkvy8ya-racerd-unstable-2019-09-02.drv' failed with exit code 101; last 10 log lines:
     |                                                           ^^

  error: aborting due to 3 previous errors

  For more information about this error, try `rustc --explain E0061`.
  error: could not compile `rustc-ap-rustc_data_structures`.

  To learn more, run the command again with --verbose.
  warning: build failed, waiting for other jobs to finish...
  error: build failed
cannot build derivation '/nix/store/0mp6w4xh9c22bj5xp7q688m5vgwc24bc-ycmd-2020-02-22.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/dhymwgknb0iwyw5533a53hwjp4a2a6gy-vimplugin-YouCompleteMe-2020-07-15.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/fydi7fk9gzmf5q314d58g5rmmkx43bsk-env.drv': 1 dependencies couldn't be built
[0 built (1 failed)]

@ndarwincorn
Copy link
Contributor Author

ndarwincorn commented Jul 19, 2020 •
edited

@typetetris - confirmed, this is the version of YCM in generated.nix prior to my update:

builder for '/nix/store/6rb7gicz0chyxw26q3w7r6ff6bkvy8ya-racerd-unstable-2019-09-02.drv' failed with exit code 101; last 10 log lines:
     |                                                           ^^
  
  error: aborting due to 3 previous errors
  
  For more information about this error, try `rustc --explain E0061`.
  error: could not compile `rustc-ap-rustc_data_structures`.
  
  To learn more, run the command again with --verbose.
  warning: build failed, waiting for other jobs to finish...
  error: build failed
cannot build derivation '/nix/store/0mp6w4xh9c22bj5xp7q688m5vgwc24bc-ycmd-2020-02-22.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/h3wryjpdjaza7jvah581qy8s0yifsxqg-vimplugin-YouCompleteMe-2020-07-07.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/nqssandmm5fw4rscf58d5k0x4ayrjqmk-env.drv': 1 dependencies couldn't be built

@teto teto merged commit 3350c92 into NixOS:master Jul 19, 2020
@ndarwincorn ndarwincorn deleted the vimplugins branch July 29, 2020 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@typetetris typetetris typetetris left review comments

@jonringer jonringer Awaiting requested review from jonringer

@jorsn jorsn Awaiting requested review from jorsn

@jagajaga jagajaga Awaiting requested review from jagajaga

Assignees
No one assigned
Labels
6.topic: vim 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 11-100 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ndarwincorn @typetetris @teto @Janik-Haag