Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rocm-runtime: make ROCR_EXT_DIR handling more local #93388

Merged
merged 1 commit into from Jul 18, 2020
Merged

rocm-runtime: make ROCR_EXT_DIR handling more local #93388

merged 1 commit into from Jul 18, 2020

Conversation

danieldk
Copy link
Contributor

Motivation for this change

Make ROCR_EXT_DIR handling more local. Avoid that our patching messes up loading other libraries.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@danieldk danieldk requested a review from acowley July 18, 2020 05:56
@danieldk danieldk mentioned this pull request Jul 18, 2020
Merged
@danieldk danieldk requested a review from Flakebi July 18, 2020 05:57
@danieldk
Copy link
Contributor Author

Wow, the diff of the diff looks ugly. Quick link to the new diff:

https://github.com/NixOS/nixpkgs/blob/6d00504061923e666218335de0b0a9440aa6a03b/pkgs/development/libraries/rocm-runtime/rocr-ext-dir.diff

@danieldk danieldk merged commit ae33b7d into NixOS:master Jul 18, 2020
@danieldk danieldk deleted the more-local-rocr-ext-dir branch July 18, 2020 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acowley acowley acowley approved these changes

@Flakebi Flakebi Awaiting requested review from Flakebi

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@danieldk @acowley