Result of nixpkgs-review pr 93406 1

• package path fits guidelines
• package name fits guidelines
• package version fits guidelines
• package build on linux x86_64
• executables tested on linux x86_64
• meta.description is set and fits guidelines
• meta.license fits upstream license
• meta.homepage is set and fits
• meta.platforms is set
• meta.maintainers is set
• build time only dependencies are declared in nativeBuildInputs
• source is fetched using the appropriate function
• phases are respected

Maybe set meta.platforms = stdenv.lib.platforms.all or some such?

checkInputs is automatically included in nativeBuildInputs if doCheck = true. So maybe thats unnecessary listed twice?

checkInputs is automatically included in nativeBuildInputs if doCheck = true. So maybe thats unnecessary listed twice?

Yes it could, but I got those separated so it is clear that octave and libxml2 are only used when running tests. Merging both would work flawlessly but I am not sure it will improve maintainability.

I suggest to remove them from nativeBuildInputs. And just keep them in checkInputs.

oh, actually I just realized that octave and libxml2 are present in both. All my excuses for that, they are only meant to be in checkInputs. Your interrogations makes more sense to me now 😓

I didn't measure it, but you should only set doCheck = true in the default.nix when the build time of the test isn't a lot.