Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rink: 0.4.5 -> 0.5.0 #93404

Merged
merged 1 commit into from Jul 18, 2020
Merged

rink: 0.4.5 -> 0.5.0 #93404

merged 1 commit into from Jul 18, 2020

Conversation

dywedir
Copy link
Member

@dywedir dywedir commented Jul 18, 2020

Motivation for this change

https://github.com/tiffany352/rink-rs/releases/tag/v0.5.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from sbourdeauducq and Br1ght0ne July 18, 2020 10:53
@typetetris
Copy link
Contributor

Result of nixpkgs-review pr 93404 1

1 package built:
- rink

@typetetris
Copy link
Contributor

[x] version fits guideline
[x] commit text fits guidelines
[x] package maintainers are notified
[x] meta field information is correct
[x] code contains no typos
[x] package built / executable was run

@typetetris
Copy link
Contributor

Cool stuff, didn't know about rink. Every physics student should know about that!

typetetris
typetetris approved these changes Jul 18, 2020
View reviewed changes
Copy link
Contributor

@typetetris typetetris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Br1ght0ne
Br1ght0ne approved these changes Jul 18, 2020
View reviewed changes
Copy link
Member

@Br1ght0ne Br1ght0ne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Thanks @dywedir for the PR and @typetetris for the detailed review!

@Br1ght0ne Br1ght0ne merged commit b907241 into NixOS:master Jul 18, 2020
@sbourdeauducq
Copy link
Contributor

Every physics student should know about that!

More experienced physicists also use it :)

@dywedir dywedir deleted the rink branch July 19, 2020 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@typetetris typetetris typetetris approved these changes

@Br1ght0ne Br1ght0ne Br1ght0ne approved these changes

@sbourdeauducq sbourdeauducq Awaiting requested review from sbourdeauducq

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dywedir @typetetris @sbourdeauducq @Br1ght0ne