Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/gitlab: Support pages #93426

Merged
merged 1 commit into from Oct 11, 2020
Merged

nixos/gitlab: Support pages #93426

merged 1 commit into from Oct 11, 2020

Conversation

dasJ
Copy link
Member

@dasJ dasJ commented Jul 18, 2020 •
edited

Motivation for this change

Closes #84525

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dasJ
Copy link
Member Author

dasJ commented Jul 18, 2020

@GrahamcOfBorg build gitlab-pages

@dasJ dasJ changed the title Feat/gitlab pages nixos/gitlab: Support pages Jul 18, 2020
@dali99
Copy link
Member

dali99 commented Jul 19, 2020

fixes #84525

@dasJ dasJ requested a review from flokli August 21, 2020 16:50
@dasJ
Copy link
Member Author

dasJ commented Aug 21, 2020

@GrahamcOfBorg eval

@ofborg ofborg bot requested a review from kalbasit September 1, 2020 10:35
@dasJ dasJ requested a review from Lassulus September 2, 2020 20:21
@flokli flokli merged commit a6fec75 into NixOS:master Oct 11, 2020
@ajs124 ajs124 deleted the feat/gitlab-pages branch October 12, 2020 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajs124 ajs124 ajs124 approved these changes

@alyssais alyssais Awaiting requested review from alyssais

@andir andir Awaiting requested review from andir

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@jtojnar jtojnar Awaiting requested review from jtojnar

@flokli flokli Awaiting requested review from flokli

@kalbasit kalbasit Awaiting requested review from kalbasit

@Lassulus Lassulus Awaiting requested review from Lassulus

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Package Request: gitlab-pages
4 participants
@dasJ @dali99 @ajs124 @flokli