Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

strip-nondeterminism: fix build on darwin #93427

Merged
merged 1 commit into from Jul 18, 2020
Merged

strip-nondeterminism: fix build on darwin #93427

merged 1 commit into from Jul 18, 2020

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Jul 18, 2020

Motivation for this change

Fixes #93414

cc: @zaninime

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Jul 18, 2020
zaninime
zaninime approved these changes Jul 18, 2020
View reviewed changes
Copy link
Contributor

@zaninime zaninime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me. I didn't know the shebang had a size limit. I just found out a related issue #35353 and a similar fix #66446 (adding for posterity).

@marsam marsam merged commit c28899b into NixOS:master Jul 18, 2020
@marsam marsam deleted the fix-strip-nondeterminism-darwin branch July 18, 2020 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zaninime zaninime zaninime approved these changes

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

strip-nondeterminism: broken on Darwin
2 participants
@marsam @zaninime