nixosTests.taskserver: Port to python #93413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tfc
reviewed
Jul 27, 2020
tfc
reviewed
Jul 27, 2020
|
Wow this is one of the longer nixos tests. Thank you for porting this! |
liff
force-pushed
the
taskserver-python-test
branch
from
75b010c
to
6b1c347
Compare
|
@GrahamcOfBorg test taskserver |
aszlig
reviewed
Aug 15, 2020
| pass | ||
|
|
||
|
|
||
| def setup_clients_for(org, user, extra_init=no_extra_init): |
There was a problem hiding this comment.
Why not use None instead and call the function IFF extra_init is not None?
There was a problem hiding this comment.
Just to keep the call site slightly simpler, I guess. This is longer than it needs to be, though, since the no_extra_init function could be replaced by just lambda: None.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Making progress on #72828. Very much just a mechanical translation.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)