nixos/gitlab: Support incoming mail #93424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this deserves some addition to nixos/modules/services/misc/gitlab.xml. Can you include it into this PR?
|
When incoming mails are enabled, an extra service is needed. Closes NixOS#36125.
dasJ
force-pushed
the
feat/gitlab-mailroom
branch
from
0aa6010
to
ae1dada
Compare
|
@flokli Done |
|
@ofborg eval |
ofborg
bot
added
10.rebuild-linux: 1-10
10.rebuild-linux: 1
and removed
10.rebuild-linux: 0
labels
flokli
reviewed
Sep 5, 2020
| <para> | ||
| When <literal>icoming_mail.enabled</literal> is set to <literal>true</literal> | ||
| in <link linkend="opt-services.gitlab.extraConfig">extraConfig</link> an additional | ||
| service called <literal>gitlab-mailroom</literal> is enabled for fetching incoming mail. |
There was a problem hiding this comment.
How do I configure this service? Does it use whatever sendmail is configured? Is there a configuration example somewhere we could link to?
There was a problem hiding this comment.
I don't think we want to copy the upstream manual here and I don't feel like their links are stable at all (like their repo layouts). Also, sendmail has nothing to do with it, since this is about receiving mail and not sending it ;)
There was a problem hiding this comment.
Right - incoming_mail.enabled is probably enough of breadcrumbs for people to scroll down to "Example for source installs:" in https://docs.gitlab.com/ee/administration/incoming_email.html.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When incoming mails are enabled, an extra service is needed.
Closes #36125.
Motivation for this change
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)