libappindicator: 12.10.0 -> 12.10.1+20.10.20200706.1 #93453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This moves libappindicator to use a different upstream source. Rather than use the 8 year old (!) version displayed on its homepage (https://launchpad.net/libappindicator), this switches us to the maintained lp:libappindicator branch, browseable over here: https://code.launchpad.net/~indicator-applet-developers/libappindicator/trunk. This includes numerous fixes, remains updated, and matches what ubuntu uses. Due to a personal preference for git over bzr, I have the package using ubuntu's git mirror of the package for the source rather than the bzr repo where I _think_ development actually takes place. This also removes the no-python patch, because per revision 292 (https://bazaar.launchpad.net/~indicator-applet-developers/libappindicator/trunk/revision/292), that has been dropped from upstream already, so the patch is no longer needed. The primary motivation behind this change is to fix a crash with libappindicator (reported https://bugs.launchpad.net/ubuntu/+source/libappindicator/+bug/1867996 and in various other places). The relevant patch for that should be included in this version.
|
cc @msteen since you're marked as the maintainer of this package, and may have a better idea if there are any other caveats I may need to be aware of about this libappindicator bump. |
10 tasks
benley
approved these changes
Aug 25, 2020
10 tasks
jonringer
approved these changes
Aug 25, 2020
There was a problem hiding this comment.
LGTM
failures are broken on target branch
https://github.com/NixOS/nixpkgs/pull/93453
3 packages failed to build:
quodlibet-full quodlibet-xine-full steam-run-native
74 packages built:
Sylk appimage-run audio-recorder autokey blueman deltachat-electron devdocs-desktop discord discord-canary discord-ptb dropbox dropbox-cli gitter gnome3.gnome-control-center networkmanagerapplet gromit-mpx gspeech gxneur handbrake hubstaff indicator-application-gtk2 indicator-application-gtk3 irccloud joplin-desktop kazam keybase-gui ledger-live-desktop libappindicator libappindicator-gtk2 marktext mate.caja-dropbox mate.mate-control-center mate.mate-polkit meteo minetime minishift modem-manager-gui mullvad-vpn notable obsidian pantheon.elementary-greeter pantheon.switchboard-plug-network pantheon.switchboard-with-plugs pantheon.wingpanel-with-indicators pasystray perl528Packages.Gtk2AppIndicator perl530Packages.Gtk2AppIndicator syncthing-gtk radiotray-ng redshift redshift-plasma-applet redshift-wlr remmina runwayml safeeyes sc-controller shutter signal-desktop skypeforlinux slack ssb-patchwork standardnotes station syncthing-tray systrayhelper tusk udiskie uget uget-integrator ulauncher unityhub wootility xflux-gui zulip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves libappindicator to use a different upstream source. Rather
than use the 8 year old (!) version displayed on its homepage
(https://launchpad.net/libappindicator), this switches us to the
maintained lp:libappindicator branch, browseable over here:
https://code.launchpad.net/~indicator-applet-developers/libappindicator/trunk.
This includes numerous fixes, remains updated, and matches what ubuntu
uses.
Due to a personal preference for git over bzr, I have the package using
ubuntu's git mirror of the package for the source rather than the bzr
repo where I think development actually takes place.
This also removes the no-python patch, because per revision 292
(https://bazaar.launchpad.net/~indicator-applet-developers/libappindicator/trunk/revision/292),
that has been dropped from upstream already, so the patch is no longer
needed.
The primary motivation behind this change is to fix a crash with
libappindicator (reported
https://bugs.launchpad.net/ubuntu/+source/libappindicator/+bug/1867996
and in various other places).
The relevant patch for that should be included in this version.
Motivation for this change
Fix crashes in libappindicator apps that have been fixed in the more-up-to-date upstream fork of libappindicator (maintained by canonical)
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)Note: For "tested compilation of all packages", it did result in failures:
For those error packages, picking a random set to retry manually, I get that they're marked as broken due to a transitive dependency on a broken gst-plugins-base. For example:
I didn't see a clean way to exaustively verify all of them were broken in that same way, but the ones I sampled were.