Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

convos: fix tests #93419

Merged
merged 1 commit into from Jul 19, 2020
Merged

convos: fix tests #93419

merged 1 commit into from Jul 19, 2020

Conversation

stigtsp
Copy link
Member

@stigtsp stigtsp commented Jul 18, 2020 •
edited

  • Patch for time() dependent test started to fail after 1594263232.
  • Patch for disk space test that fails on zfs.
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@stigtsp stigtsp requested a review from talyz July 18, 2020 13:34
@danieldk
Copy link
Contributor

nix-review build fails with:

#   Failed test 'similar match for JSON Pointer "/disk_usage/dev"'
#   at t/web-admin.t line 28.
#                   'rpool/local/root'
#     doesn't match '(?^:/dev/)'
Use of uninitialized value in pattern match (m//) at /build/source/blib/lib/Convos/Controller/Admin.pm line 50.
# Looks like you failed 1 test of 63.
t/web-admin.t .................... Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/63 subtests 
t/web-base-url.t ................. 1/? [2020-07-18 17:19:56.43523] [802] [error] [OJICQax7] X-Request-Base header was seen, but CONVOS_REVERSE_PROXY is not set

@stigtsp stigtsp force-pushed the package/convos-4.23-fix-impure-test branch from a06b7f4 to 22ad3c5 Compare July 18, 2020 19:21
@stigtsp stigtsp changed the title convos: fix time() dependent test convos: fix tests Jul 18, 2020
@stigtsp
Copy link
Member Author

stigtsp commented Jul 18, 2020

nix-review build fails with:

@danieldk Thanks for reviewing. I've updated the commit to include a patch for the failed test on zfs as well.

@danieldk
Copy link
Contributor

Still fails with the same error, but you probably already saw that in AArch64 ofborg.

@stigtsp
convos: fix tests
0c21a99 
- Patch for time() dependent test started to fail after 1594263232.
- Patch for disk space test that fails on zfs.
@stigtsp stigtsp force-pushed the package/convos-4.23-fix-impure-test branch from 22ad3c5 to 0c21a99 Compare July 19, 2020 18:22
@danieldk
Copy link
Contributor

Third time's a charm 🍀 . Works now!

@danieldk danieldk merged commit 2981e5d into NixOS:master Jul 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieldk danieldk danieldk approved these changes

@talyz talyz Awaiting requested review from talyz

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@stigtsp @danieldk