Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sgtk-menu: init at 1.4.1 #93456

Closed
wants to merge 2 commits into from
Closed

sgtk-menu: init at 1.4.1 #93456

wants to merge 2 commits into from

Conversation

berbiche
Copy link
Member

Motivation for this change

Packages sgtk-menu. Fixes #78370.

The wiki mentions the package python-pynput is needed to spawn the widget at the pointer location but python-pynput is not currently packaged.

cc @eoli3n if you want to test this out.

When testing the program, right clicks made sgtk-grid exit successfully without launching any application.
I don't know whether this is intended behavior since I've never used the program before.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@berbiche
Copy link
Member Author

This package is also relevant for #57602

@pbogdan
Copy link
Member

pbogdan commented Jul 19, 2020

Just a note that there is also an open PR for packaging the C++ version - #93189

strictDeps = false;

meta = with stdenv.lib; {
description = "A themeable, searchable, gtk3-based system launcher.";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description = "A themeable, searchable, gtk3-based system launcher.";
description = "A themeable, searchable, gtk3-based system launcher";

As per https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md

@symphorien
Copy link
Member

When clicking on the lock button, it seems that it depends on swaylock. I wonder if the path should be hardcoded.

@berbiche
Copy link
Member Author

When clicking on the lock button, it seems that it depends on swaylock. I wonder if the path should be hardcoded.

Good point. Swaylock is only used when sgtk-menu detects that it's running on Sway.

I don't know whether substituteAll is more appropriate than setting the path in the wrapper.

@symphorien
Copy link
Member

Good point. Swaylock is only used when sgtk-menu detects that it's running on Sway.

well it does not detect right because I tested on i3.

@berbiche
Copy link
Member Author

Good point. Swaylock is only used when sgtk-menu detects that it's running on Sway.

well it does not detect right because I tested on i3.

This is the code responsible for detecting your WM
https://github.com/nwg-piotr/sgtk-menu/blob/b253f8cc6b025635125b4b9e4a6023c20b4b8e35/sgtk_menu/tools.py#L20-L77

Just a note that there is also an open PR for packaging the C++ version - #93189

Judging by the code activity on sgtk-menu, it will eventually be archived.

I will close this PR in favor of #93189.

@berbiche berbiche closed this Jul 19, 2020
@berbiche berbiche mentioned this pull request Jul 19, 2020
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sgtk-menu
3 participants