New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
haskellPackages.pandoc-sidenote: 0.19.0.0 -> 0.20.0.0, remove broken #93421
haskellPackages.pandoc-sidenote: 0.19.0.0 -> 0.20.0.0, remove broken #93421
Conversation
@minijackson Thanks for trying to fix this up. Normally we don't completely overwrite packages this way, since someone will have to remember to undo it when it is updated upstream. The first thing I'd suggest you do is to create an issue upstream asking for a new release. Normally package maintainers are pretty happy to make a new release for compatibility purposes. If you make an issue on the upstream repo and the author doesn't reply, then we should try to fix this up in nixpkgs. Normally we do it by just calling |
Oh, I just read the issue you linked to in the code. I'd post a comment to that issue urging the author to make another release to Hackage. However, if the author's decision is to not make any more releases to Hackage, than we have a separate way of supporting packages that aren't actually on hackage. You might want to take a quick look at the I guess another solution is to take over the package on Hackage and do the uploads in place of the actual author. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I very much prefer a solution that gets a proper release onto Hackage. Overriding the src
attribute of a released package is really a lost resort kind-of solution that I'd rather avoid.
Are there any news about this endeavor? @minijackson, did you have any success convincing upstream to release a new version? |
@peti I think you have as much information as I have, I haven't been contacting the maintainer of pandoc-sidenote, and I haven't seen a response in the aforementioned issue upstream |
Need to override pandoc-sidenote: NixOS/nixpkgs#93421
@minijackson Are you still interested in this? On jez/pandoc-sidenote#14 (comment), the author of this package says that he'd be happy for someone to takeover this package on Hackage, so maybe you could contact the Hackage maintainers and ask to be added as a maintainer for this package? That would allow you to upload 0.20.0.0. |
@cdepillabout Ah well, it'd be awesome, but I do not have nearly enough knowledge of Haskell, nor Pandoc / Pandoc-sidenote to do that, I'm merely just an end user ^^ |
The author released a new version to Hackage: https://hackage.haskell.org/package/pandoc-sidenote-0.22.1.0 In the next couple days, you may want to rebase this PR on (Also, saying thanks to the author on jez/pandoc-sidenote#14 would probably be a kind gesture!) |
@minijackson All you need to do at this point is to revert the changes you made to The version of pandoc-sidenote released on hackage is compatible with the version of pandoc in nixpkgs, so once it's not marked as broken anymore, it can at least be distributed to unstable. Correct me if this is wrong, I'm relatively new to nix :) |
7e69821
to
43be1e7
Compare
This should be good now, sorry for the delay |
Can confirm. Thank you! |
Whoops, this should've gone to |
Motivation for this change
pandoc-sidenote 0.20.0.0 does compile and work with our current version of pandoc. It just isn't released on hackage: jez/pandoc-sidenote#14
I'm fairly new to nixpkgs' haskell ecosystem, please do tell if there is a better way to do this.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)