Cleanup newline-removal in manifest_build.py #24540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a small follow-up to d7423b4, which was an attempt at a hotfix that turned out to be the problem. To tidy up the code, trim the sha at retrieval time and don't trim the tag (which turned out not to have a newline in it).
This seems to be caused by my change #24520 . I'll fix it up. Though I'm not sure why my PR passed the test... |
|
Ahh no it didn't... I misread (or perhaps forgot to refresh?) the page... Force-merging this one for now and the fix will follow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small follow-up to d7423b4,
which was an attempt at a hotfix that turned out to be the problem. To
tidy up the code, trim the sha at retrieval time and don't trim the tag
(which turned out not to have a newline in it).