Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fslint: init at 2.46 #92833

Merged
merged 1 commit into from Aug 16, 2020
Merged

fslint: init at 2.46 #92833

merged 1 commit into from Aug 16, 2020

Conversation

dasj19
Copy link
Contributor

@dasj19 dasj19 commented Jul 10, 2020 •
edited

Motivation for this change

Packaging fslint as requested here: #92768

Right now we have a fslint running.
There is some functionality like "installed packages" which is hardcoded for deb/rpm distros. That obviously does not work on nix.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dasj19 dasj19 mentioned this pull request Jul 10, 2020
Closed
@dasj19
Copy link
Contributor Author

dasj19 commented Jul 10, 2020

The "Installed packages" functionality does not work on nix as it is hardcoded for deb/rpm distros. Do we even want to add support for that?

Everything else works fine for me, the default.nix file might need a little grooming otherwise this is good to go.

Review needed.

@ehmry
Copy link
Contributor

ehmry commented Jul 10, 2020

Works for me.

@magnetophon
Copy link
Member

👍 Works for me!

@dasj19 dasj19 force-pushed the fslint-init branch 2 times, most recently from 6fbcce3 to 30f117a Compare August 10, 2020 13:38
@dasj19
Copy link
Contributor Author

dasj19 commented Aug 10, 2020 •
edited

made small adjustments to the installPhase and changed patchPhase into prePatch.
The software still runs as expected.

Ran nix path-info -Sh $(which fslint) which results in
/nix/store/24j64ddbq21gs8ziayw7h44a0ssj93xp-fslint-2.46 844.8M

@flokli flokli merged commit 9ca1f49 into NixOS:master Aug 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehmry ehmry ehmry left review comments

@sikmir sikmir sikmir left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dasj19 @ehmry @magnetophon @sikmir @flokli