Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

loop: 2018-12-04 -> 2020-07-08 #92817

Merged
merged 1 commit into from Jul 11, 2020
Merged

loop: 2018-12-04 -> 2020-07-08 #92817

merged 1 commit into from Jul 11, 2020

Conversation

uosis
Copy link
Contributor

@uosis uosis commented Jul 9, 2020

Motivation for this change

Version upgrade to get new features.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

endgame
endgame approved these changes Jul 10, 2020
View reviewed changes
Copy link
Contributor

@endgame endgame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built with nix-build -A loop https://github.com/uosis/nixpkgs/archive/3a78e394629a781f6c924619f60e546a0737c62e.tar.gz and tested. It seems to work.

danieldk
danieldk suggested changes Jul 10, 2020
View reviewed changes
pkgs/tools/misc/loop/default.nix Outdated Show resolved Hide resolved
@uosis uosis requested a review from danieldk July 10, 2020 22:16
danieldk
danieldk suggested changes Jul 11, 2020
View reviewed changes
Copy link
Contributor

@danieldk danieldk left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now. Could you squash the two commits into one with the following commit message?

loop: unstable-2018-12-04 -> unstable-2020-07-08

@uosis uosis requested a review from danieldk July 11, 2020 15:12
danieldk
danieldk approved these changes Jul 11, 2020
View reviewed changes
Copy link
Contributor

@danieldk danieldk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Result of nixpkgs-review pr 92817 1

1 package built:
- loop

Checked that loop works.

@danieldk danieldk merged commit a091844 into NixOS:master Jul 11, 2020
@uosis uosis deleted the update-loop branch July 14, 2020 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieldk danieldk danieldk approved these changes

@endgame endgame endgame approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@uosis @danieldk @endgame