Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

powerline: fix fish integration #92808

Merged
merged 1 commit into from Nov 29, 2020
Merged

powerline: fix fish integration #92808

merged 1 commit into from Nov 29, 2020

Conversation

justin-gerhardt
Copy link
Contributor

@justin-gerhardt justin-gerhardt commented Jul 9, 2020 •
edited

Motivation for this change

#92712 was merged yesterday, simplifying the installation of shell integrations. It missed that the fish integration had to be installed to a sub folder and as a result broke it.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@drewrisinger
Copy link
Contributor

Diff LGTM & builds cleanly, but unsure how to test it. Don't know enough about this. Any tips?

@justin-gerhardt
Copy link
Contributor Author

If you want to test that it works you can install the patched powershell package, install fish, and run powerline-setup in the fish shell. You should now see the powerline prompt (On the current version you would get a not found error). Note: You may see some font breaking on the prompt depending on the terminal/font.

drewrisinger
drewrisinger approved these changes Jul 9, 2020
View reviewed changes
Copy link
Contributor

@drewrisinger drewrisinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Diff LgTM
  • Commits LGTM
  • Builds clean
  • WASN'T able to replicate testing environment.

@SuperSandro2000 SuperSandro2000 merged commit 7c90866 into NixOS:master Nov 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drewrisinger drewrisinger drewrisinger approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@justin-gerhardt @drewrisinger @SuperSandro2000