Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reland "Do not expose media devices before a successful getUserMedia()" #24532

Merged
merged 1 commit into from Jul 27, 2020

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Jul 9, 2020

This reverts commit 69a6001995c51516b403dbde99a2db4c5054ce55.

chrome-prefixed URLs are exempted from the getUserMedia() requirement.

Original change's description:

Revert "Do not expose media devices before a successful getUserMedia()"

This reverts commit d64e736aa8c7976b12b33f92472f7950bf0215b9.

Reason for revert: Caused chrome_all_tast_tests / camera.CCAUISanity.fake failures; e.g. https://ci.chromium.org/p/chrome/builders/ci/chromeos-betty-pi-arc-chrome/7680

Original change's description:

Do not expose media devices before a successful getUserMedia()

This is a spec-compliance change.

This CL also adds some improvements to the blink MediaDevices unit test.

Bug: 1101860
Change-Id: If2e7824df3b3dbd3cdb80f4bcf6b5c417d6f0ef2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279808
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Harald Alvestrand <hta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#786253}

TBR=hta@chromium.org,guidou@chromium.org

Change-Id: I41b676c7d3e437c06d23f2b46270453f1cc81670
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1101860
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288282
Reviewed-by: Mohsen Izadi <mohsen@chromium.org>
Commit-Queue: Mohsen Izadi <mohsen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#786615}

TBR=mohsen@chromium.org,hta@chromium.org,guidou@chromium.org

Not skipping CQ checks because this is a reland.

Bug: 1101860
Change-Id: I3fb6d9a620291cda57eb5fe48ce330b45425a5bc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289833
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Harald Alvestrand <hta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791797}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Chromium project.

This reverts commit 69a6001995c51516b403dbde99a2db4c5054ce55.

chrome-prefixed URLs are exempted from the getUserMedia() requirement.

Original change's description:
> Revert "Do not expose media devices before a successful getUserMedia()"
>
> This reverts commit d64e736aa8c7976b12b33f92472f7950bf0215b9.
>
> Reason for revert: Caused chrome_all_tast_tests / camera.CCAUISanity.fake failures; e.g. https://ci.chromium.org/p/chrome/builders/ci/chromeos-betty-pi-arc-chrome/7680
>
> Original change's description:
> > Do not expose media devices before a successful getUserMedia()
> >
> > This is a spec-compliance change.
> >
> > This CL also adds some improvements to the blink MediaDevices unit test.
> >
> > Bug: 1101860
> > Change-Id: If2e7824df3b3dbd3cdb80f4bcf6b5c417d6f0ef2
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279808
> > Commit-Queue: Guido Urdaneta <guidou@chromium.org>
> > Reviewed-by: Harald Alvestrand <hta@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#786253}
>
> TBR=hta@chromium.org,guidou@chromium.org
>
> Change-Id: I41b676c7d3e437c06d23f2b46270453f1cc81670
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 1101860
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288282
> Reviewed-by: Mohsen Izadi <mohsen@chromium.org>
> Commit-Queue: Mohsen Izadi <mohsen@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#786615}

TBR=mohsen@chromium.org,hta@chromium.org,guidou@chromium.org

# Not skipping CQ checks because this is a reland.

Bug: 1101860
Change-Id: I3fb6d9a620291cda57eb5fe48ce330b45425a5bc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289833
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Harald Alvestrand <hta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791797}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants