Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-add paint_invalidation_container in PrePaintTreeWalk. #24550

Merged
merged 1 commit into from Jul 10, 2020

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Jul 10, 2020

This is needed in order to make sure to call
SetNeedsCheckRasterInvalidation() on all GraphicsLayers that
need raster invalidation after an invalidation of paint. To do
this involves finding out into which GraphicsLayer a LayoutObject paints.

We'll be able to remove it in favor of a dirty bit on
CompositingLayerAssigner when pre-paint is moved before compositing.

Bug: 1102733

Change-Id: I506d7e574e802502d9414ad67f14f0d4c072b184
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2290547
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Auto-Submit: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#787058}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Chromium project.

This is needed in order to make sure to call
SetNeedsCheckRasterInvalidation() on all GraphicsLayers that
need raster invalidation after an invalidation of paint. To do
this involves finding out into which GraphicsLayer a LayoutObject paints.

We'll be able to remove it in favor of a dirty bit on
CompositingLayerAssigner when pre-paint is moved before compositing.

Bug: 1102733

Change-Id: I506d7e574e802502d9414ad67f14f0d4c072b184
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2290547
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Auto-Submit: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#787058}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants