Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC 0071] Retired Committers Amendment #71

Merged
merged 2 commits into from Aug 27, 2020
Merged

Conversation

worldofpeace
Copy link
Contributor

@worldofpeace worldofpeace commented Jul 9, 2020

@worldofpeace
Copy link
Contributor Author

#55 (comment)

@blaggacao
Copy link
Contributor

Meta topic:

Albeit

Submit a pull request. Rename the rfcs with the PR number. (eg: PR #123 would be rfcs/0123-my-feature.md)

in my experience it would be better to directly amend. git keeps the audit logs anyway.

@asymmetric
Copy link
Contributor

Bikeshedding mode: past or former both sound better to me than retired. Retired makes me thinks of retirees, i.e. old people who stopped working.

@samueldr
Copy link
Member

samueldr commented Jul 9, 2020

in my experience it would be better to directly amend. git keeps the audit logs anyway.

The README already states:

In general, once accepted, RFCs should not be substantially changed. Only very minor changes should be submitted as amendments. More substantial changes should be new RFCs, with a note added to the original RFC. Exactly what counts as a "very minor change" is up to the RFC Shepherd Team of the RFC to be amended, to be decided in cooperation with the RFC Steering Committee.

This might be sitting firmly on the fence of "substantial change". The original RFC being relatively thin in contents (and rightly so), this does change what is definitely arguably a portion of it.

This is probably a situation where when there is doubt, prefer sending an RFC so the full process can be followed. ¯\_(ツ)_/¯

@worldofpeace
Copy link
Contributor Author

worldofpeace commented Jul 10, 2020

Bikeshedding mode: past or former both sound better to me than retired. Retired makes me thinks of retirees, i.e. old people who stopped working.

A nice thing that @grahamc mentioned was that neither of those can have an honor designation like the former word emiritus. An example is someone returning from retirement, and they're an esteemed person.

@lheckemann lheckemann added status: open for nominations Open for shepherding team nominations and removed status: new labels Jul 16, 2020
@lheckemann
Copy link
Member

This RFC is now open for shepherd nominations.

I nominate myself.

@worldofpeace
Copy link
Contributor Author

I'd also want to nominate the author of the RFC this amends @tilpner, and I guess @alyssais.
You can probably tell that the time commitment for this one is super low, you really could comment a yes/no 😁

@tilpner
Copy link
Member

tilpner commented Jul 17, 2020

I'm not particularly attached to the team name of #55, and this RFC sounds sensible to me.
There are no open questions from my side, and I would be in favor of accepting it.

@alyssais
Copy link
Member

alyssais commented Jul 21, 2020 via email

@worldofpeace worldofpeace added status: in discussion and removed status: open for nominations Open for shepherding team nominations labels Jul 30, 2020
@worldofpeace
Copy link
Contributor Author

worldofpeace commented Jul 30, 2020

We've accepted the nominations for shepherds @lheckemann @tilpner @alyssais, and our leader is @tilpner.
This is now in discussion.

@worldofpeace
Copy link
Contributor Author

Everyone has already pre-approved on this RFC. Perhaps the shepherds can comment we could move to FCP?
@lheckemann @tilpner @alyssais

Copy link
Member

@lheckemann lheckemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm go for FCP, @tilpner / @alyssais ?

@alyssais
Copy link
Member

alyssais commented Aug 17, 2020 via email

@tilpner
Copy link
Member

tilpner commented Aug 17, 2020

Yes, please go ahead to FCP.

@worldofpeace
Copy link
Contributor Author

Cool, motion for FCP with a disposition to merge.

@worldofpeace worldofpeace added status: FCP in Final Comment Period and removed status: in discussion labels Aug 17, 2020
@lheckemann lheckemann merged commit 3d280b6 into NixOS:master Aug 27, 2020
@lheckemann lheckemann added status: accepted and removed status: FCP in Final Comment Period labels Aug 27, 2020
@worldofpeace worldofpeace deleted the 0071 branch August 27, 2020 14:56
KAction pushed a commit to KAction/rfcs that referenced this pull request Apr 13, 2024
Co-authored-by: Jörg Thalheim <Mic92@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants