Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.notifymuch: Init at 0.1 #92797

Closed
wants to merge 2 commits into from
Closed

python3Packages.notifymuch: Init at 0.1 #92797

wants to merge 2 commits into from

Conversation

glittershark
Copy link
Member

@glittershark glittershark commented Jul 9, 2020 •
edited

Motivation for this change

I'd like to use the package

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@glittershark glittershark requested a review from bbigras July 9, 2020 19:24
@bbigras
Copy link
Contributor

bbigras commented Jul 10, 2020

Reviewed points
  • package path fits guidelines
  • package name fits guidelines
  • package version fits guidelines
  • package build on x86_64
  • executables tested on x86_64
  • meta.description is set and fits guidelines
  • meta.license fits upstream license
  • meta.platforms is set
  • meta.maintainers is set
  • build time only dependencies are declared in nativeBuildInputs
  • source is fetched using the appropriate function
  • phases are respected
  • patches that are remotely available are fetched with fetchpatch
Possible improvements
  • set meta.platforms
Comments

last commit was 5 years ago but it works.

I ran it and I saw a notification with my unread messages.

@bbigras
Copy link
Contributor

bbigras commented Jul 21, 2020

@glittershark friendly ping

@glittershark
Copy link
Member Author

@bbigras done.

@bbigras
Copy link
Contributor

bbigras commented Jul 30, 2020

It's Linux only? I have no idea how notifications work on mac.

@glittershark
Copy link
Member Author

I marked it linux only because I haven't tested it on mac. I can only assume that since it's very much tied to gobject/gtk libnotify this wouldn't work on mac, which uses its own notification thingy

@bbigras
Copy link
Contributor

bbigras commented Jul 30, 2020

Gotcha. Thanks.

@glittershark
Copy link
Member Author

/status needs_merge

@glittershark
Copy link
Member Author

/marvin opt-in

@marvin-mk2 marvin-mk2 bot added the marvin label Jul 30, 2020
@marvin-mk2
Copy link

marvin-mk2 bot commented Jul 30, 2020

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/236

@glittershark
Copy link
Member Author

/status needs_merger

@marvin-mk2
Copy link

marvin-mk2 bot commented Jul 30, 2020

The PR author cannot set the status to needs_merger. Please wait for an external review.

If you are not the PR author and you are reading this, please review the usage of this bot. You may be able to help. Please make an honest attempt to resolve all outstanding issues before setting to needs_merger.

jonringer
jonringer reviewed Jul 30, 2020
View reviewed changes
pkgs/development/python-modules/notifymuch/default.nix
Comment on lines +39 to +45
preFixup = ''
echo "wrapper args"
echo "''${makeWrapperArgs[@]}"
makeWrapperArgs+=("''${gappsWrapperArgs[@]}")
echo "wrapper args again"
echo "''${makeWrapperArgs[@]}"
'';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
preFixup = ''
echo "wrapper args"
echo "''${makeWrapperArgs[@]}"
makeWrapperArgs+=("''${gappsWrapperArgs[@]}")
echo "wrapper args again"
echo "''${makeWrapperArgs[@]}"
'';
makeWrapperArgs = [ "''${gappsWrapperArgs[@]}" ]

pkgs/development/python-modules/notifymuch/default.nix
buildPythonApplication rec {
pname = "notifymuch";
version = "0.1";
disabled = ! isPy3k;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
disabled = ! isPy3k;
disabled = !isPy3k;

pkgs/development/python-modules/notifymuch/default.nix
@@ -0,0 +1,56 @@
{ stdenv
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not directly used

Suggested change
{ stdenv
{ lib

pkgs/development/python-modules/notifymuch/default.nix

strictDeps = false;

meta = with stdenv.lib; {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
meta = with stdenv.lib; {
meta = with lib; {

@bbigras
Copy link
Contributor

bbigras commented Aug 5, 2020

/status awaiting_changes

@bbigras
Copy link
Contributor

bbigras commented Aug 12, 2020

@glittershark friendly ping

@bbigras
Copy link
Contributor

bbigras commented Aug 19, 2020

@glittershark friendly ping. Can we get this in the release please?

@glittershark
Copy link
Member Author

yeah, I'll try to get to this in the next day or so. Been swamped with $dayjob

@marvin-mk2 marvin-mk2 bot requested a review from timokau September 20, 2020 03:56
@timokau
Copy link
Member

timokau commented Sep 21, 2020

/status awaiting_changes

@SuperSandro2000
Copy link
Member

@glittershark ping

@stale
Copy link

stale bot commented Jun 3, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 3, 2021
@arjan-s
Copy link
Contributor

arjan-s commented Mar 18, 2022 •
edited

@glittershark ping
I'd love to be able to use this package. Could you make the requested changes so that it can be merged?

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Mar 18, 2022
@SuperSandro2000 SuperSandro2000 added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Mar 19, 2022
@SuperSandro2000
Copy link
Member

I'd love to be able to use this package. Could you make the requested changes so that it can be merged?

You can also just create a new PR with the changes and we close this one.

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Mar 27, 2022
@arjan-s arjan-s mentioned this pull request Mar 28, 2022
Merged
13 tasks
@arjan-s
Copy link
Contributor

arjan-s commented Mar 28, 2022

You can also just create a new PR with the changes and we close this one.

Okay, thanks for your answer. I've created a new PR here with the requested changes: #166075

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer left review comments

@bbigras bbigras bbigras approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@timokau timokau Awaiting requested review from timokau

Assignees
No one assigned
Labels
2.status: merge conflict 6.topic: python 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 0 11.by: package-maintainer awaiting_changes marvin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@glittershark @bbigras @nixos-discourse @timokau @SuperSandro2000 @arjan-s @jonringer @ryantm