Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

firefox{,-bin}: add 'mesa', for wayland/drm #92823

Merged
merged 1 commit into from Jul 11, 2020
Merged

firefox{,-bin}: add 'mesa', for wayland/drm #92823

merged 1 commit into from Jul 11, 2020

Conversation

colemickens
Copy link
Member

Motivation for this change

Woot! This puts to bed the mystery of why our Firefox builds (firefox, firefox-bin, latest.firefox-nightly-bin, etc) all report wayland instead of wayland/drm under about:support.

From the source here https://searchfox.org/mozilla-central/source/widget/gtk/DMABufLibWrapper.cpp#157 I enabled logging, ran Firefox and determined it was lacking libgbm which I know comes from mesa.

My understanding is that this should provide significant benefits, and maybe have implications for enabling some perf gains that were meant to be enabled with the previous vaapi-enablement.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@colemickens
Copy link
Member Author

I very strongly suspects that this also "fixes" firefox-nightly-bin, but I haven't had time to confirm yet.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/hardware-acceleration-on-firefox/7947/11

@ofborg ofborg bot requested a review from taku0 July 10, 2020 03:06
@flokli flokli merged commit 2bb6bc6 into NixOS:master Jul 11, 2020
@colemickens colemickens deleted the firefox-drm branch December 30, 2022 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@taku0 taku0 Awaiting requested review from taku0

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@colemickens @nixos-discourse @jonringer @flokli