Add: [CMake] Source group definitions for MSVC project filters. #8264
+39
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ated project files (like the old MSVC projects).
|
Maybe add a comment about using source_group(TREE ...) for when we upgrade to 3.8 ? (Or just upgrade to 3.8 anyway?) |
|
I have CMake 3.17 locally here and I wasn't able to get anything useful out of |
LordAro
approved these changes
Jul 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I kinda liked the logical grouping of the source files in the old MSVC project. This commit restores this grouping in the generated project files.
I tried adding the source_group definitions to the appropriate CMakeLists, but apparently this just doesn't work: https://stackoverflow.com/questions/31422680/how-to-set-visual-studio-filters-for-nested-sub-directory-using-cmake