New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Codechange: Spell 'Viewport' consistently #8260
Conversation
Nothing will break as far as I know, go ahead and do the strings as well :) |
It won't break the translation/localisation system? |
Nah. Probably. |
Translations should be safe if everything match. The translation system always reads the updated strings. |
I thought that only applied to translations? What we are proposing here is to change the symbolic identifiers; things would break horribly if they weren't consistent all the way through, yeah? |
17eead3
to
6dcde46
Compare
6dcde46
to
bea33f1
Compare
bea33f1
to
96937df
Compare
Oops, didn‘t need to rebase this one. Sorry about that. (I wonder if I can undo it? 🤔) |
96937df
to
bea33f1
Compare
Only by (effectively) rebasing again. Why would you want to anyway? |
Habit, I guess. Most of my PRs seem to end up conflicting with each other one way or another. |
bea33f1
to
b823268
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not especially waiting on anything
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
b823268
to
f2ba109
Compare
Some places in the codebase misspell 'Viewport' as 'ViewPort' or 'view_port'. This patch makes everything consistent.
f2ba109
to
69fdaa5
Compare
Some places in the codebase misspell 'Viewport' as 'ViewPort' or 'view_port'.
This patch makes everything consistent.
There are several strings that are named
VIEW_PORT
and/orVIEWPORT
. I have left these alone because I do not know what will break.