Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.03] samba: 4.11.9 -> 4.11.11 #92844

Merged
merged 1 commit into from Jul 23, 2020
Merged

[20.03] samba: 4.11.9 -> 4.11.11 #92844

merged 1 commit into from Jul 23, 2020

Conversation

mmilata
Copy link
Member

@mmilata mmilata commented Jul 10, 2020 •
edited

Changes:

Unstable update (has 4.12 branch): #92570

Motivation for this change

Fixes bunch of DoS:

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from aneeshusa July 10, 2020 10:46
@mweinelt
Copy link
Member

@GrahamcOfBorg test samba

@mweinelt
Copy link
Member

Thanks!

@mweinelt mweinelt merged commit afd465f into NixOS:staging-20.03 Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aneeshusa aneeshusa Awaiting requested review from aneeshusa

Assignees
No one assigned
Labels
1.severity: security 8.has: package (update) 10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mmilata @mweinelt