Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ngircd: 25 -> 26 #92843

Merged
merged 1 commit into from Jul 23, 2020
Merged

ngircd: 25 -> 26 #92843

merged 1 commit into from Jul 23, 2020

Conversation

mmilata
Copy link
Member

@mmilata mmilata commented Jul 10, 2020

Motivation for this change

Fixes: https://nvd.nist.gov/vuln/detail/CVE-2020-14148
New version: https://github.com/ngircd/ngircd/blob/rel-26/ChangeLog

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

nixpkgs-update fails with a funny error:

2020-07-05T17:52:23 ngircd 25 -> 26 https://repology.org/metapackage/ngircd/versions
2020-07-05T17:52:36 [version] 
2020-07-05T17:52:37 FAIL stderr did not split as expected full stderr was: 
error: anonymous function at /var/cache/nixpkgs-update/nixpkgs/pkgs/build-support/fetchurl/default.nix:38:1 called with unexpected argument 'sha266', at /var/cache/nixpkgs-update/nixpkgs/pkgs/servers/irc/ngircd/default.nix:6:9

@mweinelt
Copy link
Member

LGTM, thanks!

Result of nixpkgs-review pr 92843 1

1 package built:
- ngircd

@mweinelt mweinelt merged commit c24ad29 into NixOS:master Jul 23, 2020
@mweinelt mweinelt mentioned this pull request Oct 1, 2020
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
1.severity: security 8.has: package (update) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mmilata @mweinelt