Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

oneshot: init at 1.0.1 #92792

Merged
merged 1 commit into from Jul 13, 2020
Merged

oneshot: init at 1.0.1 #92792

merged 1 commit into from Jul 13, 2020

Conversation

milibopp
Copy link
Contributor

@milibopp milibopp commented Jul 9, 2020

Motivation for this change

I use the package and want to make it easily available to other nixpkgs users.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from kalbasit July 9, 2020 14:40
danieldk
danieldk suggested changes Jul 11, 2020
View reviewed changes
Copy link
Contributor

@danieldk danieldk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already looks pretty good! Added some small suggested changes.

pkgs/tools/networking/oneshot/default.nix Outdated Show resolved Hide resolved
pkgs/tools/networking/oneshot/default.nix Outdated Show resolved Hide resolved
pkgs/tools/networking/oneshot/default.nix Show resolved Hide resolved
@milibopp
Copy link
Contributor Author

Thanks @danieldk for the review. I committed your non-optional changes as requested, so should be ready to merge now.

Also I noticed that there is an update to 1.1.0 already available and updated accordingly. I hope that's okay. If you prefer me to submit a second PR for that update, let me know and I will split it.

@danieldk
Copy link
Contributor

Also I noticed that there is an update to 1.1.0 already available and updated accordingly. I hope that's okay.

That's fine! Could you squash all commits into one and use the following commit message?

oneshot: init at 1.1.0

@milibopp
Copy link
Contributor Author

done

danieldk
danieldk approved these changes Jul 13, 2020
View reviewed changes
Copy link
Contributor

@danieldk danieldk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 92792 1

1 package built:
- oneshot

The build report was served through oneshot itself before copy-pasting into this post ;).

@danieldk danieldk merged commit 9c28b51 into NixOS:master Jul 13, 2020
@milibopp milibopp deleted the oneshot branch July 13, 2020 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieldk danieldk danieldk approved these changes

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@milibopp @danieldk