buildDartPackage: init, dart-sass: init at 1.26.10 #92814

tadfisher · 2020-07-09T22:09:55Z

Motivation for this change

The sass tool is outdated, and is no longer the reference SASS implementation. The reference implementation is now dart-sass, which is written in Dart and runs under the Dart VM. However, nixpkgs lacks a convenience builder for Dart applications.

This adds a buildDartPackage function, which builds Dart applications using the standard pub package manager and dart VM from the Dart SDK. The resulting compiled snapshots will run on any architecture supported by the Dart VM. A wrapper script is generated for launching snapshots using the Dart VM built by nixpkgs.

See doc/languages-frameworks/dart.section.md (rendered) for documentation.

Things done

nixos-discourse · 2020-07-23T19:46:45Z

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/227

jonringer

I think the docs deserve their own commit

doc/languages-frameworks/dart.section.md

pkgs/build-support/dart/default.nix

pkgs/development/tools/dart-sass/default.nix

pkgs/top-level/all-packages.nix

tadfisher · 2020-07-31T18:49:11Z

@jonringer Split documentation change into its own commit, and addressed your other feedback. Thank you!

jtacoma · 2020-12-29T03:54:35Z

Hey, this would be nice to have! It might later extended or forked to support building Flutter packages too!

I tried verifying on OSX, but my OSX environment is slightly broken right now.

I was unable to verify on Linux due to hash mismatch in fixed-output derivation '/nix/store/vkb6pj840jggj84fy75kaglxpzk7jksp-dart-sass-deps-1.26.10'. In fact, this is the same error that ofborg found here. Do we need a different approach to this problem? (Random thought: would a fromYAML directive be helpful?)

nixos-discourse · 2021-04-22T17:20:05Z

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/506

roberth · 2021-04-22T17:46:38Z

Is it feasible to fetch and hash the packages individually?

Right now if a package changes, there's no way to know what happened, let alone recover. Large (fragile) fixed-output derivations do make builds unreproducible.

SuperSandro2000 · 2021-04-22T19:44:59Z

pkgs/development/tools/dart-sass/default.nix

+    sass = "sass";
+  };
+
+  meta = with stdenv.lib; {


Suggested change

meta = with stdenv.lib; {

meta = with lib; {

SuperSandro2000 · 2021-04-22T19:45:08Z

pkgs/development/tools/dart-sass/default.nix

@@ -0,0 +1,28 @@
+{ stdenv, fetchFromGitHub, buildDartPackage }:


Suggested change

{ stdenv, fetchFromGitHub, buildDartPackage }:

{ lib, stdenv, fetchFromGitHub, buildDartPackage }:

SuperSandro2000 · 2021-04-22T19:45:27Z

pkgs/build-support/dart/default.nix

+    set -x
+    export PUB_CACHE="${pubCache}"
+    pub get --offline --no-precompile
+    ${buildSnapshots}


Suggested change

set -x

export PUB_CACHE="${pubCache}"

pub get --offline --no-precompile

${buildSnapshots}

set -x

export PUB_CACHE="${pubCache}"

pub get --offline --no-precompile

${buildSnapshots}

SuperSandro2000 · 2021-04-22T19:45:44Z

pkgs/build-support/dart/default.nix

+    inherit (stdenv.lib) concatStringsSep mapAttrsToList;
+    buildSnapshot = name: path:
+      with stdenv.lib; ''


Suggested change

inherit (stdenv.lib) concatStringsSep mapAttrsToList;

buildSnapshot = name: path:

with stdenv.lib; ''

inherit (lib) concatStringsSep mapAttrsToList;

buildSnapshot = name: path:

with lib; ''

SuperSandro2000 · 2021-04-22T19:45:50Z

pkgs/build-support/dart/default.nix

+
+  diff = "${diffutils.nativeDrv or diffutils}/bin/diff";
+
+  dartOpts = with stdenv.lib;


Suggested change

dartOpts = with stdenv.lib;

dartOpts = with lib;

SuperSandro2000 · 2021-04-22T19:46:13Z

pkgs/build-support/dart/default.nix

@@ -0,0 +1,165 @@
+{ stdenv, diffutils, dart, makeWrapper }:


Suggested change

{ stdenv, diffutils, dart, makeWrapper }:

{ lib, stdenv, diffutils, dart, makeWrapper }:

SuperSandro2000 · 2021-04-22T19:46:22Z

doc/languages-frameworks/index.xml

@@ -11,6 +11,7 @@
 <xi:include href="bower.xml" />
 <xi:include href="coq.xml" />
 <xi:include href="crystal.section.xml" />
+ <xi:include href="dart.section.xml" />


Please convert this to markdown.

SuperSandro2000 · 2021-04-22T19:47:06Z

doc/languages-frameworks/dart.section.md

+the value from the error output. The following output shows the value of
+`pubSha256` for the `dart-sass` expression:
+
+```


Suggested change

```

```ShellSession

SuperSandro2000 · 2021-04-22T19:47:13Z

doc/languages-frameworks/dart.section.md

+    sass = "sass";
+  };
+
+  meta = with stdenv.lib; {


Suggested change

meta = with stdenv.lib; {

meta = with lib; {

SuperSandro2000 · 2021-04-22T19:47:18Z

doc/languages-frameworks/dart.section.md

+expression for building `dart-sass`:
+
+```nix
+{ stdenv, fetchFromGitHub, buildDartPackage }:


Suggested change

{ stdenv, fetchFromGitHub, buildDartPackage }:

{ lib, stdenv, fetchFromGitHub, buildDartPackage }:

tadfisher · 2021-05-16T21:35:13Z

@roberth Agreed; I am now using a different approach in https://github.com/tadfisher/nix-dart, although that repository requires flakes for now. I think I'll close this and look at porting that mechanism instead.

roberth · 2021-05-16T23:00:31Z

@tadfisher I'm glad you've found an even better approach. When porting those expressions to Nixpkgs, keep in mind that Hydra won't let you import from derivation (e.g. import "${nix-dart}/something.nix", but same for builtins.readFile etc).
If the derivation is static, you can copy the necessary files into nixpkgs and import those instead. If changes are necessary, hopefully upstream can be refactored to make maintenance easier.
If the derivation is a function of "user input" such as the package source they're trying to build, we'll need to work around that for packages that are packaged in Nixpkgs itself. For packages outside Nixpkgs, using a function that uses import from derivation is acceptable.

ofborg bot added 8.has: documentation 8.has: package (new) 11.by: package-maintainer 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Jul 9, 2020

jonringer reviewed Jul 30, 2020

View reviewed changes

tadfisher added 3 commits July 31, 2020 11:44

buildDartPackage: init

d55ff34

doc: Add Dart language section

3aee7d1

dart-sass: init at 1.26.10

981130f

tadfisher force-pushed the dart-sass branch from d0c2665 to 981130f Compare July 31, 2020 18:47

tadfisher requested a review from jonringer November 28, 2020 21:52

SuperSandro2000 requested changes Apr 22, 2021

View reviewed changes

tadfisher closed this May 16, 2021

zopieux mentioned this pull request Oct 3, 2021

Integration/use in upstream nixpkgs tadfisher/nix-dart#3

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

buildDartPackage: init, dart-sass: init at 1.26.10 #92814

buildDartPackage: init, dart-sass: init at 1.26.10 #92814

tadfisher commented Jul 9, 2020 •

edited

nixos-discourse commented Jul 23, 2020

jonringer left a comment

tadfisher commented Jul 31, 2020

jtacoma commented Dec 29, 2020

nixos-discourse commented Apr 22, 2021

roberth commented Apr 22, 2021

SuperSandro2000 Apr 22, 2021

SuperSandro2000 Apr 22, 2021

SuperSandro2000 Apr 22, 2021

SuperSandro2000 Apr 22, 2021

SuperSandro2000 Apr 22, 2021

SuperSandro2000 Apr 22, 2021

SuperSandro2000 Apr 22, 2021

SuperSandro2000 Apr 22, 2021

SuperSandro2000 Apr 22, 2021

SuperSandro2000 Apr 22, 2021

tadfisher commented May 16, 2021

roberth commented May 16, 2021

		@@ -0,0 +1,28 @@
		{ stdenv, fetchFromGitHub, buildDartPackage }:

	{ stdenv, fetchFromGitHub, buildDartPackage }:
	{ lib, stdenv, fetchFromGitHub, buildDartPackage }:


		diff = "${diffutils.nativeDrv or diffutils}/bin/diff";

		dartOpts = with stdenv.lib;

	{ stdenv, diffutils, dart, makeWrapper }:
	{ lib, stdenv, diffutils, dart, makeWrapper }:

buildDartPackage: init, dart-sass: init at 1.26.10 #92814

buildDartPackage: init, dart-sass: init at 1.26.10 #92814

Conversation

tadfisher commented Jul 9, 2020 • edited

Motivation for this change

Things done

nixos-discourse commented Jul 23, 2020

jonringer left a comment

Choose a reason for hiding this comment

tadfisher commented Jul 31, 2020

jtacoma commented Dec 29, 2020

nixos-discourse commented Apr 22, 2021

roberth commented Apr 22, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tadfisher commented May 16, 2021

roberth commented May 16, 2021

tadfisher commented Jul 9, 2020 •

edited