Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some basic Oscillator tests #24541

Merged
merged 1 commit into from Jul 10, 2020

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Jul 9, 2020

Test the output of the OscillatorNode for a sine wave at various
frequencies (including a negative frequency) against the exact
mathematical output. The low frequencies are intended to test
Chrome's interpolation algorithm.

Since we use sine waves or custom waves with a very few known
coefficients (without normalization), we know what the exact output
should be.

Bug: 1013118
Change-Id: Ie68ef5a8e6979aab70d0a4d4c24ee31810599f56
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2290693
Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#787297}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Chromium project.

Test the output of the OscillatorNode for a sine wave at various
frequencies (including a negative frequency) against the exact
mathematical output.  The low frequencies are intended to test
Chrome's interpolation algorithm.

Since we use sine waves or custom waves with a very few known
coefficients (without normalization), we know what the exact output
should be.

Bug: 1013118
Change-Id: Ie68ef5a8e6979aab70d0a4d4c24ee31810599f56
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2290693
Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#787297}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants