@FRidh I pushed the version that tries to use certbot.overridePythonAttrs, but doesn't work. Can you take a look? Otherwise, I'd propose to just drop the last commit and merge as-is.

See https://github.com/FRidh/nixpkgs/tree/certbot for what I would say is the preferred solution.

Agreed. Thanks for the commits! I pushed them to this PR (slightly modifying HEAD~1) while doing so. PTAL.

I'll squash the commits adding the withPlugins feature, but I think having individual commits of the refactor/move itself should make things more understandable.

The trailing whitespace cleanups are harder to get rid of, my editor is really persistent on cleaning these up :-D I'll see if I can move them into a individual commit, so git blame is happy - we should really just have a github check preventing them from occuring in first place IMHO.

Can I use this inside my system configuration? Not sure how to configure it

environment.systemPackages = with pkgs; [
  (certbot.withPackages (ps: with ps; [ certbot-dns-inwx ] ) )
];

You need to use certbot.withPlugins, not certbot.withPackages, so the following would work:

certbot.withPlugins (ps: with ps; [ certbot-dns-cloudflare ])

Note certbot-dns-inwx isn't packaged yet, but you can take a look at the other existing certbox-dns-* plugins, happy to review a PR adding inwx :-)

Thanks that worked for me, at least importing the plugin where I have the PR here #190677

Unfortunately it doesn't get recognized yet

 environment.systemPackages = with pkgs; [
   ( certbot.withPlugins (ps: with ps; [ python310Packages.certbot-dns-inwx ]) )
 ];

[root@piproxy:~]# certbot certonly -a dns-inwx -d example.org
Saving debug log to /var/log/letsencrypt/letsencrypt.log
The requested dns-inwx plugin does not appear to be installed
Ask for help or search for solutions at https://community.letsencrypt.org. See the logfile /var/log/letsencrypt/letsencrypt.log or re-run Certbot with -v for more details.

Let's take this over to the PR, this is unrelated to the introduction of certbot.withPlugins itself.