[LayoutNG] Only spanner siblings are considered adjacent. #24534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jul 9, 2020
The spec isn't crystal clear, but unconditionally considering spanners that are siblings of another spanner's ancestors as adjacent is definitely wrong. We need to resume column content layout inside the parent block of the spanner, since it may have a fixed block-size, block-end padding / border, or anything else that we'd just lose otherwise. This breaks one existing (non-WPT) test, but I'm not convinced that the test is valid. Filed crbug.com/1100849 for it. It also fixes 3 WPT tests. They were all quite complex, so I added a couple of simple ones, that demonstrate this fix more to the point. Bug: 829028 Change-Id: I9d55153f859dd84a5019e7d4dd09453f7f9ee1e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2290150 Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#786841}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2290150
branch
from
f8ad986
to
48bbf88
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The spec isn't crystal clear, but unconditionally considering spanners
that are siblings of another spanner's ancestors as adjacent is
definitely wrong. We need to resume column content layout inside the
parent block of the spanner, since it may have a fixed block-size,
block-end padding / border, or anything else that we'd just lose
otherwise.
This breaks one existing (non-WPT) test, but I'm not convinced that the
test is valid. Filed crbug.com/1100849 for it.
It also fixes 3 WPT tests. They were all quite complex, so I added a
couple of simple ones, that demonstrate this fix more to the point.
Bug: 829028
Change-Id: I9d55153f859dd84a5019e7d4dd09453f7f9ee1e4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2290150
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#786841}