Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

network manager plugins (iodine/vpnc) without gnome #92838

Merged
merged 2 commits into from Aug 17, 2020
Merged

network manager plugins (iodine/vpnc) without gnome #92838

merged 2 commits into from Aug 17, 2020

Conversation

dguibert
Copy link
Member

@dguibert dguibert commented Jul 10, 2020 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@doronbehar
Copy link
Contributor

@dguibert this seems interesting but I'm not sure I get the motivation or what this does.

@dguibert dguibert force-pushed the dg/network-manager-plugin-without-gnome branch from b8ba372 to f13d54f Compare August 17, 2020 08:47
@dguibert
Copy link
Member Author

@dguibert this seems interesting but I'm not sure I get the motivation or what this does.

This patch allows to compile these plugins when setting in your configuration.nix

environment.noXlibs = true

@jtojnar jtojnar merged commit edadf13 into NixOS:master Aug 17, 2020
@jtojnar
Copy link
Contributor

jtojnar commented Aug 17, 2020

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar left review comments

@obadz obadz Awaiting requested review from obadz

@domenkozar domenkozar Awaiting requested review from domenkozar

@worldofpeace worldofpeace Awaiting requested review from worldofpeace

@Phreedom Phreedom Awaiting requested review from Phreedom

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dguibert @doronbehar @jtojnar