Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ocrmypdf: 9.8.2 -> 10.2.0 #92789

Merged
merged 2 commits into from Jul 11, 2020
Merged

ocrmypdf: 9.8.2 -> 10.2.0 #92789

merged 2 commits into from Jul 11, 2020

Conversation

bachp
Copy link
Member

@bachp bachp commented Jul 9, 2020

Motivation for this change

Update to latest version.

coloredlogs is required in a newer version, so I updated its too.

Things done

@flokli @Mic92 I enabled the tests as discussed in #89710

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bachp bachp changed the title Ocrmypdf 10.2.0 ccrmypdf: 9.8.2 -> 10.2.0 Jul 9, 2020
@ofborg ofborg bot requested review from Kiwi and eyJhb July 9, 2020 12:54
@bachp bachp changed the title ccrmypdf: 9.8.2 -> 10.2.0 ocrmypdf: 9.8.2 -> 10.2.0 Jul 10, 2020
flokli
flokli requested changes Jul 11, 2020
View reviewed changes
pkgs/tools/text/ocrmypdf/default.nix Outdated Show resolved Hide resolved
@bachp bachp requested a review from flokli July 11, 2020 19:11
@flokli flokli merged commit 4b18e4c into NixOS:master Jul 11, 2020
@bachp bachp deleted the ocrmypdf-10.2.0 branch July 11, 2020 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@Kiwi Kiwi Awaiting requested review from Kiwi

@eyJhb eyJhb Awaiting requested review from eyJhb

@flokli flokli Awaiting requested review from flokli

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bachp @flokli @eyJhb