Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parsedmarc: init at 6.10.0 #92836

Closed
wants to merge 5 commits into from
Closed

parsedmarc: init at 6.10.0 #92836

wants to merge 5 commits into from

Conversation

fadenb
Copy link
Contributor

@fadenb fadenb commented Jul 10, 2020

Motivation for this change

Parsedmarc is not yet available in nixpkgs.
I plan to provide a service module soon.

Things done
  • Added missing python dependencies
  • Added parsedmarc
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

jonringer
jonringer reviewed Aug 5, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are no tests included. Please try to checkout from source and check if they have unit tests, and try to run them. Unit tests give a good indication that they package has a high degree of validity and correctness given the python package set.

If tests are not available, then please use pythonImportsCheck to import the most important modules. This isn't as good as unit tests, but will usually give a good indication of run-time errors.


----------------------------------------------------------------------
Ran 0 tests in 0.000s

pkgs/development/python-modules/expiringdict/default.nix Outdated Show resolved Hide resolved
pkgs/tools/misc/parsedmarc/default.nix Show resolved Hide resolved
@fadenb fadenb requested a review from jonringer August 12, 2020 13:51
@fadenb fadenb mentioned this pull request Aug 28, 2020
Closed
10 tasks
@stale
Copy link

stale bot commented Apr 7, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Apr 7, 2021
@fadenb
Copy link
Contributor Author

fadenb commented Apr 7, 2021

There is some activity on #96533. Basically the lack of a new enough elastic held me back to push forward on this. I intend to pick it up again soon-ish as I have a renewed need for parsedmarc.

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Apr 7, 2021
@ajs124 ajs124 mentioned this pull request Jun 2, 2021
Merged
9 tasks
@fadenb
Copy link
Contributor Author

fadenb commented Aug 30, 2021

Made obsolete by #125404 :)

@fadenb fadenb closed this Aug 30, 2021
@fadenb fadenb deleted the parsedmarc_python branch August 30, 2021 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@puzzlewolf puzzlewolf puzzlewolf left review comments

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
2.status: merge conflict 6.topic: python 8.has: documentation 8.has: package (new) 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@fadenb @jonringer @puzzlewolf @ryantm