First functional tests for scrollbar-gutter
#24554
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests for the values "auto", "stable" and "always" of the scrollbar-gutter property with custom classic scrollbars. Spec: https://drafts.csswg.org/css-overflow-4/#scrollbar-gutter-property
|
Is this PR still needed? It seems the tests are already added via other PRs. |
|
@aethanyc You are right, this PR is no longer needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests for the values
auto,stableandalwaysof thescrollbar-gutterproperty, using classic scrollbars.Spec: https://drafts.csswg.org/css-overflow-4/#scrollbar-gutter-property
The basic test works by comparing the size of the container and contained elements, which should be the same unless a scrollbar gutter is being shown.
It uses
scrollbar-widthand::-webkit-scrollbarto ensure that the scrollbars are of the "classic" kind. Testing scrollbar-gutter with overlay scrollbars will probably require browser-specific tests, since there isn't a cross-platform way to ensure the presence of overlay scrollbars.